Re: [PATCH] Add compat_ioctl to st

[Andi Kleen <ak@muc.de>]

On Tue, Jan 18, 2005 at 11:23:57AM +0000, Christoph Hellwig wrote:
> > +#ifdef CONFIG_COMPAT
> > +static int st_compat_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
> > +{
> > +	struct scsi_tape *STp = file->private_data;
> > +	struct scsi_device *sdev = STp->device;
> > +	int ret = -ENOIOCTLCMD;
> > +	if (sdev->host->hostt->compat_ioctl) { 
> > +
> > +		ret = sdev->host->hostt->compat_ioctl(sdev, cmd, arg);
> 
> This seems to miss a cast for arg.  Also I think it would be really nice
> to have a little helper like:

Hmm, yes.

Well, there are so many warnings in the code currently anyways
that one more won't really hurt ;-) 

> 
> int scsi_compat_ioctl(struct scsi_device *sdev, unsigned int cmd,
> 		unsiged long arg)
> {
> 	struct scsi_host_template *hostt = sdev->host->hostt;
> 	if (hostt->compat_ioctl)
> 		return hostt->compat_ioctl(sdev, cmd, (void __user *)arg);
> 	return -ENOIOCTLCMD;
> }
> 
> that all drivers could use.

I don't think this makes sense for three lines of code. 

-Andi