From: Andi Kleen <ak@muc.de>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] Add compat_ioctl to scsi host structure
Date: 19 Jan 2005 00:27:45 +0100
Date: Wed, 19 Jan 2005 00:27:45 +0100 [thread overview]
Message-ID: <20050118232745.GA66256@muc.de> (raw)
In-Reply-To: <1106062536.5151.2.camel@mulgrave>
On Tue, Jan 18, 2005 at 07:35:36AM -0800, James Bottomley wrote:
> On Tue, 2005-01-18 at 12:03 +0100, Andi Kleen wrote:
> > Add a call vector for 32bit compat ioctls to the SCSI host
> > structure. This is needed for some followon patches.
> >
> > Signed-off-by: Andi Kleen <ak@muc.de>
>
> Shouldn't this also be surrounded by #ifdef CONFIG_COMPAT (on the
> grounds that you never fill it in unless CONFIG_COMPAT is defined)?
At least the standard file_operations has it without ifdef.
I guess it doesn't hurt too much even on non compat systems.
-Andi
next prev parent reply other threads:[~2005-01-18 23:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-18 11:03 [PATCH] Add compat_ioctl to scsi host structure Andi Kleen
2005-01-18 15:35 ` James Bottomley
2005-01-18 23:27 ` Andi Kleen [this message]
2005-01-19 15:55 ` James Bottomley
2005-01-19 16:03 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050118232745.GA66256@muc.de \
--to=ak@muc.de \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox