From: Greg KH <greg@kroah.com>
To: Christoph Hellwig <hch@lst.de>
Cc: jejb@steeleye.com, James.Smart@Emulex.Com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] drop some attibutes from the FC transport class
Date: Wed, 19 Jan 2005 09:21:06 -0800 [thread overview]
Message-ID: <20050119172106.GB32702@kroah.com> (raw)
In-Reply-To: <20050119171357.GA16136@lst.de>
On Wed, Jan 19, 2005 at 06:13:57PM +0100, Christoph Hellwig wrote:
> I think the hardware_version, firmware_version, rom_version and
> driver_version don't belong into the FC transport class, there's
> nothign specific to FC or even SCSI specific in them.
Then put them in the individual driver (not the driver_version one
though, that belongs as a MODULE_VERSION() paramater).
> If you want these attributes talk to Greg about fiding a place in
> the common driver model code for them.
No, they don't belong there either, sorry :)
thanks,
greg k-h
next prev parent reply other threads:[~2005-01-19 17:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-19 17:13 [PATCH] drop some attibutes from the FC transport class Christoph Hellwig
2005-01-19 17:21 ` Greg KH [this message]
2005-01-19 18:38 ` Brian King
2005-01-19 18:45 ` Greg KH
2005-01-19 22:59 ` Brian King
2005-01-19 21:39 ` Mike Anderson
2005-01-19 22:40 ` Greg KH
2005-01-19 23:03 ` Brian King
2005-01-19 23:03 ` Christoph Hellwig
2005-01-19 23:08 ` Greg KH
2005-01-19 23:15 ` Matt Domsch
2005-01-19 23:42 ` Greg KH
2005-01-20 5:12 ` Matt Domsch
2005-01-20 14:41 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2005-01-19 17:25 James.Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050119172106.GB32702@kroah.com \
--to=greg@kroah.com \
--cc=James.Smart@Emulex.Com \
--cc=hch@lst.de \
--cc=jejb@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox