From: Oliver Neukum <oliver@neukum.org>
To: James Bottomley <James.Bottomley@steeleye.com>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: Ooops unmounting a defect DVD
Date: Sat, 29 Jan 2005 18:44:41 +0100 [thread overview]
Message-ID: <200501291844.41290.oliver@neukum.org> (raw)
In-Reply-To: <1107009976.4535.13.camel@mulgrave>
Am Samstag, 29. Januar 2005 15:46 schrieb James Bottomley:
> I wouldn't have noticed this at all since you didn't send it to the scsi
> list, but fortunately, Al Viro drew it politely to my attention as
> another example of SCSI refcounting problems.
Sorry, it happening in cdrom_release fooled me into considering it
a generic cdrom problem.
> The issue seems to be that we have a spurious scsi_cd_put() on the error
> path of sr_open(). The sr_block_..() functions are the "real" block
> opens and should be refcounted, the sr_...() are the pseudo cdrom opens
> and should not be refcounted.
>
> Could you try this and see if it fixes the problem?
It fully fixes the problem. Thank you.
Regards
Oliver
prev parent reply other threads:[~2005-01-29 17:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-29 14:46 Ooops unmounting a defect DVD James Bottomley
2005-01-29 17:44 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200501291844.41290.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=James.Bottomley@steeleye.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox