From: Andi Kleen <ak@muc.de>
To: "Ju, Seokmann" <sju@lsil.com>
Cc: James.Bottomley@HansenPartnership.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] Convert megaraid2 to compat_ioctl
Date: 3 Feb 2005 22:12:10 +0100
Date: Thu, 3 Feb 2005 22:12:10 +0100 [thread overview]
Message-ID: <20050203211210.GA53249@muc.de> (raw)
In-Reply-To: <0E3FA95632D6D047BA649F95DAB60E570366266B@exa-atlanta>
On Thu, Feb 03, 2005 at 11:01:39AM -0500, Ju, Seokmann wrote:
> On Tuesday, January 18, 2005 6:17 AM, Andi wrote:
> > Convert megaraid2 driver to new compat_ioctl entry points.
> >
> > I don't have easy access to hardware, so only compile tested.
>
> Thanks for your feedback and appreciate changes you've made.
> The changes look great to me.
> One question, though, any reason to have 'lock_kernel'?
It was hold before and I didn't want to audit all the code
to make sure it was safe to not hold it.
> Isn't it too huge to use, here?
Probably yes. If you're audited the code and feel confident
that it doesn't need it feel free to drop.
> It could lead system hung if ioctl goes to sleep for some reason.
No, lock_kernel is magically dropped on sleeps.
-Andi
next prev parent reply other threads:[~2005-02-03 21:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-03 16:01 [PATCH] Convert megaraid2 to compat_ioctl Ju, Seokmann
2005-02-03 21:12 ` Andi Kleen [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-02-07 21:01 Ju, Seokmann
2005-02-07 21:07 ` Matthew Wilcox
2005-02-07 21:12 ` James Bottomley
2005-01-18 11:17 Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050203211210.GA53249@muc.de \
--to=ak@muc.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=sju@lsil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox