public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Andrew Morton <akpm@osdl.org>, erich <erich@areca.com.tw>,
	linux-scsi@vger.kernel.org
Subject: Re: About ARECA RAID driver for Linux i386/x86-64
Date: Sun, 6 Feb 2005 14:51:20 +0000	[thread overview]
Message-ID: <20050206145120.GC834@infradead.org> (raw)
In-Reply-To: <1107425132.4278.99.camel@laptopd505.fenrus.org>

On Thu, Feb 03, 2005 at 11:05:32AM +0100, Arjan van de Ven wrote:
> * needs to use list.h lists not open coded ones

the only list uses I saw in a quick scan were for internal queueing
which should go away.  (see the tmscsim driver in 2.6 on what to return
when the queue is full)

> * uses wrong locking for the scsi layer (eg ->done should be called  
>   without locks)

it's not really wrong but totally superflous, so yes, it should go away.


  reply	other threads:[~2005-02-06 14:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <001001c508d9$d97a17f0$9300a8c0@erich2003>
2005-02-03  2:08 ` About ARECA RAID driver for Linux i386/x86-64 Andrew Morton
2005-02-03 10:05   ` Arjan van de Ven
2005-02-06 14:51     ` Christoph Hellwig [this message]
2005-02-03  4:33 erich
2005-02-03  4:51 ` Andrew Morton
2005-02-04  4:10   ` James Bottomley
2005-02-06 14:50 ` Christoph Hellwig
     [not found] <000801c514c7$04ec0030$9300a8c0@erich2003>
2005-02-18 16:10 ` Linux Christoph Hellwig
2005-02-18 19:21   ` Andrew Morton
     [not found] <000001c524bc$d3c546a0$0b02a8c0@kw.de>
     [not found] ` <000c01c52626$32bae8d0$9300a8c0@erich2003>
2005-03-11 22:27   ` Andrew Morton
2005-03-11 22:31   ` Andrew Morton
2005-03-12  0:20   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050206145120.GC834@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@osdl.org \
    --cc=arjan@infradead.org \
    --cc=erich@areca.com.tw \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox