From: Matthew Wilcox <matthew@wil.cx>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Matthew Wilcox <matthew@wil.cx>,
Grant Grundler <grundler@parisc-linux.org>,
willy@parisc-linux.org, linux-scsi@vger.kernel.org
Subject: Re: PATCH 2.6.11-rc4 rename IOMAPPED config option
Date: Mon, 21 Feb 2005 02:26:40 +0000 [thread overview]
Message-ID: <20050221022640.GC28741@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20050221021631.GA23161@havoc.gtf.org>
On Sun, Feb 20, 2005 at 09:16:31PM -0500, Jeff Garzik wrote:
> On Mon, Feb 21, 2005 at 02:14:05AM +0000, Matthew Wilcox wrote:
> > On Sun, Feb 20, 2005 at 09:09:36PM -0500, Jeff Garzik wrote:
> > > Incorrect. <linux/config.h> is not a standard include; you need to
> > > include linux/config.h in each file that uses a CONFIG_xxx define.
> >
> > sym_hipd.c includes "sym_glue.h"
> > sym_glue.h includes <linux/config.h>
> > There is no problem.
>
> Irrelevant. Go look at how config.h stuff works.
>
> linux/config.h is a special case with special rules.
>
> The rule is: include linux/config.h _in the file_ where CONFIG_xxx
> symbol is used.
Jeff, you're smoking crack. I just read fixdep.c and looked at
drivers/scsi/sym53c8xx_2/.sym_hipd.o.cmd . You're wrong.
--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
next prev parent reply other threads:[~2005-02-21 2:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-21 1:07 PATCH 2.6.11-rc4 rename IOMAPPED config option Grant Grundler
2005-02-21 1:11 ` Jeff Garzik
2005-02-21 2:02 ` Matthew Wilcox
2005-02-21 2:09 ` Jeff Garzik
2005-02-21 2:14 ` Matthew Wilcox
2005-02-21 2:16 ` Jeff Garzik
2005-02-21 2:26 ` Matthew Wilcox [this message]
2005-02-23 20:55 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050221022640.GC28741@parcelfarce.linux.theplanet.co.uk \
--to=matthew@wil.cx \
--cc=grundler@parisc-linux.org \
--cc=jgarzik@pobox.com \
--cc=linux-scsi@vger.kernel.org \
--cc=willy@parisc-linux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox