From: Christoph Hellwig <hch@infradead.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: Andrew Morton <akpm@osdl.org>, Erich Chen <erich@areca.com.tw>,
linux-kernel@vger.kernel.org, James.Bottomley@SteelEye.com,
linux-scsi@vger.kernel.org
Subject: Re: [2.6.11-rc4-mm1 patch] drivers/scsi/arcmsr/arcmsr.c cleanups
Date: Sun, 27 Feb 2005 22:23:05 +0000 [thread overview]
Message-ID: <20050227222305.GA1847@infradead.org> (raw)
In-Reply-To: <20050227154810.GA6148@stusta.de>
On Sun, Feb 27, 2005 at 04:48:10PM +0100, Adrian Bunk wrote:
> - aren't the "if defined(__x86_64__)" wrong for other 64bit
> architectures?
Yes. Having arch or 64bit ifdefs is pretty wrong pretty much always.
In one case it's only used to make a typedef a 32bit or 64bit integeger,
that should be using unsigned long directly always, but the other uses
looks like real problems.
next prev parent reply other threads:[~2005-02-27 22:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20050223014233.6710fd73.akpm@osdl.org>
2005-02-27 15:48 ` [2.6.11-rc4-mm1 patch] drivers/scsi/arcmsr/arcmsr.c cleanups Adrian Bunk
2005-02-27 22:23 ` Christoph Hellwig [this message]
2005-02-28 18:07 ` [-mm patch] drivers/scsi/ch.c: make a struct static Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050227222305.GA1847@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=erich@areca.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox