From: Christoph Hellwig <hch@infradead.org>
To: Luben Tuikov <luben_tuikov@adaptec.com>
Cc: dougg@torque.net, Adrian Bunk <bunk@stusta.de>,
James.Bottomley@SteelEye.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] SCSI: possible cleanups
Date: Tue, 1 Mar 2005 22:17:53 +0000 [thread overview]
Message-ID: <20050301221753.GA5742@infradead.org> (raw)
In-Reply-To: <42247EF0.9000404@adaptec.com>
On Tue, Mar 01, 2005 at 09:40:48AM -0500, Luben Tuikov wrote:
> On 03/01/05 03:14, Douglas Gilbert wrote:
> >> - scsi_error.c: scsi_normalize_sense
> >
> >
> >I introduced scsi_normalize_sense() recently, Christoph H.
> >proposed it should be static but Luben Tuikov (aic7xxx
> >maintainer) said he wished to use it in the future.
> >Hence it was left global.
>
> Hi guys,
>
> I think the idea of normalized sense is very good.
> Basically the question is if LLDD would submit normalized
> sense to SCSI Core or whether they would submit a pointer
> to raw sense data as returned by the device and let SCSI
> Core decipher it.
>
> If the former, then it should be global, if the latter then
> it should be static to SCSI Core.
Doing it in the core means less duplication and avoiding updating
all drivers.
next prev parent reply other threads:[~2005-03-01 22:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-28 21:31 [2.6 patch] SCSI: possible cleanups Adrian Bunk
2005-02-28 22:25 ` Christoph Hellwig
2005-02-28 23:01 ` Adrian Bunk
2005-02-28 23:34 ` Christoph Hellwig
2005-03-01 0:31 ` [2.6 patch] SCSI: cleanups Adrian Bunk
2005-03-01 8:14 ` [2.6 patch] SCSI: possible cleanups Douglas Gilbert
2005-03-01 14:40 ` Luben Tuikov
2005-03-01 22:17 ` Christoph Hellwig [this message]
2005-03-01 22:32 ` Luben Tuikov
-- strict thread matches above, loose matches on Subject: below --
2005-03-01 12:36 Salyzyn, Mark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050301221753.GA5742@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@SteelEye.com \
--cc=bunk@stusta.de \
--cc=dougg@torque.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=luben_tuikov@adaptec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox