From: domen@coderock.org
To: James.Bottomley@SteelEye.com
Cc: linux-scsi@vger.kernel.org, domen@coderock.org, nacc@us.ibm.com
Subject: [patch 02/11] scsi/st: replace schedule_timeout() with msleep_interruptible()
Date: Sun, 06 Mar 2005 23:26:53 +0100 [thread overview]
Message-ID: <20050306222654.47AD71EC90@trashy.coderock.org> (raw)
Use msleep_interruptible() instead of
schedule_timeout() to guarantee the task delays as expected.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
kj-domen/drivers/scsi/st.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff -puN drivers/scsi/st.c~msleep_interruptible-drivers_scsi_st drivers/scsi/st.c
--- kj/drivers/scsi/st.c~msleep_interruptible-drivers_scsi_st 2005-03-05 16:11:03.000000000 +0100
+++ kj-domen/drivers/scsi/st.c 2005-03-05 16:11:03.000000000 +0100
@@ -36,6 +36,7 @@ static char *verstr = "20041025";
#include <linux/moduleparam.h>
#include <linux/devfs_fs_kernel.h>
#include <linux/cdev.h>
+#include <linux/delay.h>
#include <asm/uaccess.h>
#include <asm/dma.h>
#include <asm/system.h>
@@ -760,9 +761,7 @@ static int test_ready(struct scsi_tape *
if (scode == NOT_READY) {
if (waits < max_wait) {
- set_current_state(TASK_INTERRUPTIBLE);
- schedule_timeout(HZ);
- if (signal_pending(current)) {
+ if (msleep_interruptible(1000)) {
retval = (-EINTR);
break;
}
_
next reply other threads:[~2005-03-06 22:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-06 22:26 domen [this message]
2005-03-07 17:17 ` [patch 02/11] scsi/st: replace schedule_timeout() with msleep_interruptible() Kai Makisara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050306222654.47AD71EC90@trashy.coderock.org \
--to=domen@coderock.org \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=nacc@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox