Re: [patch 1/1] scsi/osst: replace schedule_timeout() with msleep()

Willem Riede
2005-03-06T22:42:57Z

On 03/06/2005 05:27:41 PM, domen@coderock.org wrote:
>
>
> Use msleep() instead of schedule_timeout() to guarantee the task
> delays as expected. Although TASK_INTERRUPTIBLE is used in the current code,
> there is no code dealing with an early return / signals_pending().

This change is a total don't-care as far as I'm concerned. But if we are going to
make it, can we please be consistent? Does the "set_current_state(TASK_INTERRUPTIBLE)"
stay or go? The two changes below don't agree in that respect.

---
> attempts--;
> - set_current_state(TASK_INTERRUPTIBLE);
> - schedule_timeout(HZ / 10);
> + msleep(100);
> }
---
> #endif
> set_current_state(TASK_INTERRUPTIBLE);
> - schedule_timeout(HZ / 10);
> + msleep(100);
> }
---

Regards, Willem Riede,
osst maintainer.