From: Christoph Hellwig <hch@infradead.org>
To: Finn Thain <fthain@telegraphics.com.au>
Cc: James.Bottomley@SteelEye.com,
linux scsi <linux-scsi@vger.kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Noah Misch <noah@cs.caltech.edu>,
linux m68k <linux-m68k@vger.kernel.org>
Subject: Re: [PATCH] m68k link error and NCR5380_exit()
Date: Mon, 7 Mar 2005 06:37:19 +0000 [thread overview]
Message-ID: <20050307063719.GA12478@infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0503071612290.27126@loopy.telegraphics.com.au>
> .detect = macscsi_detect,
> - .release = macscsi_release,
> + .release = __exit_p(macscsi_release),
Please get rid of your ->detect/->release useage instead. Allocate
the host struct directly with scsi_host_alloc and add it when setup using
scsi_add_host/scsi_scan_host in your init routine and call scsi_remove_host/
scsi_host_put in the module exit routine. see qla1280.c for an example
that does this for the 2.6 case and to ease your porting also has the 2.4
code ifdefed so you have the direct comparism.
next prev parent reply other threads:[~2005-03-07 6:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.61.0502110155440.7310@loopy.telegraphics.com.au>
[not found] ` <20050210171518.GA22265@pants.nu>
[not found] ` <Pine.LNX.4.61.0502111930340.11381@loopy.telegraphics.com.au>
[not found] ` <Pine.LNX.4.61.0502121539440.20941@loopy.telegraphics.com.au>
[not found] ` <20050212075645.GA30669@pants.nu>
[not found] ` <Pine.LNX.4.61.0502122135230.21876@loopy.telegraphics.com.au>
[not found] ` <20050213040948.GA10198@orchestra.cs.caltech.edu>
[not found] ` <Pine.LNX.4.61.0502131618470.25204@loopy.telegraphics.com.au>
[not found] ` <20050213063225.GA17415@orchestra.cs.caltech.edu>
[not found] ` <Pine.LNX.4.61.0502131736300.25553@loopy.telegraphics.com.au>
[not found] ` <20050213075506.GA18622@orchestra.cs.caltech.edu>
[not found] ` <Pine.LNX.4.61.0502212233290.15372@loopy.telegraphics.com.au>
2005-03-07 6:30 ` [PATCH] m68k link error and NCR5380_exit() Finn Thain
2005-03-07 6:37 ` Christoph Hellwig [this message]
2005-03-07 13:45 ` Finn Thain
2005-03-07 17:53 ` Brad Boyer
2005-03-07 23:42 ` Kenn Humborg
2005-03-08 15:16 ` mac_scsi boot crash, was " Finn Thain
2005-03-08 17:39 ` Brad Boyer
2005-03-09 12:00 ` [PATCH] mac_scsi boot crash fix Finn Thain
2005-03-09 12:06 ` Kenn Humborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050307063719.GA12478@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@SteelEye.com \
--cc=fthain@telegraphics.com.au \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=noah@cs.caltech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox