[PATCH] mac_scsi boot crash fix

Finn Thain
2005-03-09T12:00:13Z

I found the bus error, the trivial fix is below.

I don't know if this patch will work for others quite yet, since my kernel
has had some work done to slow interrupt handling. I intend to post that
patch soon.

On Tue, 8 Mar 2005, Brad Boyer wrote:

> I notice it got through all the device identify stuff. It dies as soon
> as it actually tries to tranfer a real block of data (the partition map)
> and do something useful with it. Could you see if disabling PDMA helps?

I tested both: my Daystar Mac II now works great with or without PDMA, so
hopefully the IIfx will work too.

Kenn, my macs like your patch :-) Did it make it upstream?

-f

Signed-off-by: Finn Thain <fthain@telegraphics.com.au>

--- a/drivers/scsi/mac_scsi.c 2005-03-09 22:21:01.369397570 +1100
+++ b/drivers/scsi/mac_scsi.c 2005-03-09 22:02:12.594082086 +1100
@@ -302,7 +302,7 @@ int macscsi_detect(Scsi_Host_Template *

if (instance->irq != SCSI_IRQ_NONE)
if (request_irq(instance->irq, NCR5380_intr, IRQ_FLG_SLOW,
- "ncr5380", NCR5380_intr)) {
+ "ncr5380", instance)) {
printk(KERN_WARNING "scsi%d: IRQ%d not free, interrupts disabled\n",
instance->host_no, instance->irq);
instance->irq = SCSI_IRQ_NONE;