public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
* [patch 1/1] Whitelist-Entry (FORCELUN) for SGS Thomson Microelectronics Cytronix 6in1 card reader in scsi_devinfo.c
@ 2005-03-09  9:03 akpm
  2005-03-09 16:05 ` Patrick Mansfield
  2005-03-09 18:34 ` Dave Jones
  0 siblings, 2 replies; 3+ messages in thread
From: akpm @ 2005-03-09  9:03 UTC (permalink / raw)
  To: James.Bottomley; +Cc: linux-scsi, akpm, mail


From: Hanno Boeck <mail@hboeck.de>

I have a usb-cardreader here that needs some FORCELUN-entries in
scsi_devinfo.c.

lsusb says about the device:

Bus 001 Device 003: ID 0483:1307 SGS Thomson Microelectronics Cytronix 6in1 card reader

Signed-off-by: Andrew Morton <akpm@osdl.org>
---

 25-akpm/drivers/scsi/scsi_devinfo.c |    4 ++++
 1 files changed, 4 insertions(+)

diff -puN drivers/scsi/scsi_devinfo.c~whitelist-entry-forcelun-for-sgs-thomson-microelectronics-cytronix-6in1-card-reader-in-scsi_devinfoc drivers/scsi/scsi_devinfo.c
--- 25/drivers/scsi/scsi_devinfo.c~whitelist-entry-forcelun-for-sgs-thomson-microelectronics-cytronix-6in1-card-reader-in-scsi_devinfoc	2005-03-09 01:03:19.000000000 -0800
+++ 25-akpm/drivers/scsi/scsi_devinfo.c	2005-03-09 01:03:19.000000000 -0800
@@ -149,6 +149,10 @@ static struct {
 	{"Generic", "USB SD Reader", "1.00", BLIST_FORCELUN | BLIST_INQUIRY_36},
 	{"Generic", "USB Storage-SMC", "0180", BLIST_FORCELUN | BLIST_INQUIRY_36},
 	{"Generic", "USB Storage-SMC", "0207", BLIST_FORCELUN | BLIST_INQUIRY_36},
+	{"Generic", "USB Reader-SMC", NULL, BLIST_FORCELUN | BLIST_INQUIRY_36},
+	{"Generic", "USB Reader-CF", NULL, BLIST_FORCELUN | BLIST_INQUIRY_36},
+	{"Generic", "USB Reader-SD", NULL, BLIST_FORCELUN | BLIST_INQUIRY_36},
+	{"Generic", "USB Reader-MS", NULL, BLIST_FORCELUN | BLIST_INQUIRY_36},
 	{"HITACHI", "DF400", "*", BLIST_SPARSELUN},
 	{"HITACHI", "DF500", "*", BLIST_SPARSELUN},
 	{"HITACHI", "DF600", "*", BLIST_SPARSELUN},
_

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [patch 1/1] Whitelist-Entry (FORCELUN) for SGS Thomson Microelectronics Cytronix 6in1 card reader in scsi_devinfo.c
  2005-03-09  9:03 [patch 1/1] Whitelist-Entry (FORCELUN) for SGS Thomson Microelectronics Cytronix 6in1 card reader in scsi_devinfo.c akpm
@ 2005-03-09 16:05 ` Patrick Mansfield
  2005-03-09 18:34 ` Dave Jones
  1 sibling, 0 replies; 3+ messages in thread
From: Patrick Mansfield @ 2005-03-09 16:05 UTC (permalink / raw)
  To: akpm; +Cc: James.Bottomley, linux-scsi, mail

On Wed, Mar 09, 2005 at 01:03:32AM -0800, akpm@osdl.org wrote:
> 
> From: Hanno Boeck <mail@hboeck.de>
> 
> I have a usb-cardreader here that needs some FORCELUN-entries in
> scsi_devinfo.c.
> 

Hanno -

Instead of the patch, try running with CONFIG_SCSI_MULTI_LUN enabled.

-- Patrick Mansfield

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [patch 1/1] Whitelist-Entry (FORCELUN) for SGS Thomson Microelectronics Cytronix 6in1 card reader in scsi_devinfo.c
  2005-03-09  9:03 [patch 1/1] Whitelist-Entry (FORCELUN) for SGS Thomson Microelectronics Cytronix 6in1 card reader in scsi_devinfo.c akpm
  2005-03-09 16:05 ` Patrick Mansfield
@ 2005-03-09 18:34 ` Dave Jones
  1 sibling, 0 replies; 3+ messages in thread
From: Dave Jones @ 2005-03-09 18:34 UTC (permalink / raw)
  To: akpm; +Cc: James.Bottomley, linux-scsi, mail

On Wed, Mar 09, 2005 at 01:03:32AM -0800, Andrew Morton wrote:
 > 
 > From: Hanno Boeck <mail@hboeck.de>
 > 
 > I have a usb-cardreader here that needs some FORCELUN-entries in
 > scsi_devinfo.c.
 > 
 > lsusb says about the device:
 > 
 > Bus 001 Device 003: ID 0483:1307 SGS Thomson Microelectronics Cytronix 6in1 card reader
 > 
 > Signed-off-by: Andrew Morton <akpm@osdl.org>

The problem with these devices is there are so many of them,
(The Fedora kernel had over a dozen additions to the whitelist at one point),
and there were still devices getting reported that weren't detected.
There's no way to stay on top of the amount of these things that are being produced.

There are only two sane solutions that I see
1) Have usb-storage tell the scsi layer "Its a card reader, scan all luns"
or
2) enable scanning of all luns, and blacklist any devices that misbehave.

I chose (2) in the Fedora kernel, and so far, only 1 device got picked up
that needed adding to the blacklist.

		Dave


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2005-03-09 18:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-09  9:03 [patch 1/1] Whitelist-Entry (FORCELUN) for SGS Thomson Microelectronics Cytronix 6in1 card reader in scsi_devinfo.c akpm
2005-03-09 16:05 ` Patrick Mansfield
2005-03-09 18:34 ` Dave Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox