* RE: [patch 06/11] drivers/scsi/aacraid/*: convert to pci_register_driver
@ 2005-03-15 17:59 Salyzyn, Mark
2005-03-15 20:17 ` Domen Puncer
0 siblings, 1 reply; 7+ messages in thread
From: Salyzyn, Mark @ 2005-03-15 17:59 UTC (permalink / raw)
To: Domen Puncer; +Cc: James.Bottomley, linux-scsi, c.lucas
FC3 != kernel.org, and the problem may not exist in latest tree. The
code for pci_module_init used to do a return (ret < 0) ? ret : 0.
The problem is then a 'transition' issue, as patches that appear here
can and will be used for kernel revisions a few back. By changing the
aacraid driver to check for < 0 rather than != 0 we improve reliability.
I have discovered that by doing so, the driver in the Adaptec Branch
taking this patch works fine all the way back early 2.4 trees.
Sincerely -- Mark Salyzyn
-----Original Message-----
From: Domen Puncer [mailto:domen@coderock.org]
Sent: Tuesday, March 15, 2005 12:45 PM
To: Salyzyn, Mark
Cc: James.Bottomley@SteelEye.com; linux-scsi@vger.kernel.org;
c.lucas@ifrance.com
Subject: Re: [patch 06/11] drivers/scsi/aacraid/*: convert to
pci_register_driver
On 15/03/05 10:59 -0500, Salyzyn, Mark wrote:
> We have tested and seen a positive number being returned on late model
> distributions (FC3)
Function tree from 2.6.11-bk9:
pci_register_driver
driver_register
bus_add_driver
kobject_set_name - ok
kobject_register
kobject_add
create_dir
sysfs_create_dir
create_dir (different from above)
sysfs_create
init (init_dir from sysfs/dir.c) - ok
sysfs_make_dirent - ok
populate_dir
sysfs_create_file
sysfs_add_file
sysfs_make_dirent - ok
Seems ok to me. Am I missing something?
How about a "if (error > 0) dump_stack()" to find the offender?
>
> Sincerely -- Mark Salyzyn
>
> -----Original Message-----
> From: Domen Puncer [mailto:domen@coderock.org]
> Sent: Tuesday, March 15, 2005 10:57 AM
> To: Salyzyn, Mark
> Cc: James.Bottomley@SteelEye.com; linux-scsi@vger.kernel.org;
> c.lucas@ifrance.com
> Subject: Re: [patch 06/11] drivers/scsi/aacraid/*: convert to
> pci_register_driver
>
> On 15/03/05 08:38 -0500, Salyzyn, Mark wrote:
> > I have to reject this change since pci_module_init() has a different
> > return code than pci_register_driver().
>
> pci.h: #define pci_module_init pci_register_driver
>
> pci-driver.c: pci_register_driver:
> "Returns a negative value on error, otherwise 0."
>
> So... since it can't return positive number, these conditions are the
> same.
>
>
> >
> > The patch should look like:
> >
> > - error = pci_module_init(&aac_pci_driver);
> > + error = pci_register_driver(&aac_pci_driver);
> > - if (error)
> > + if (error < 0)
> > return error;
> >
> > Sincerely -- Mark Salyzyn
> >
> > -----Original Message-----
> > From: linux-scsi-owner@vger.kernel.org
> > [mailto:linux-scsi-owner@vger.kernel.org] On Behalf Of
> > domen@coderock.org
> > Sent: Sunday, March 06, 2005 5:27 PM
> > To: James.Bottomley@SteelEye.com
> > Cc: linux-scsi@vger.kernel.org; domen@coderock.org;
> c.lucas@ifrance.com
> > Subject: [patch 06/11] drivers/scsi/aacraid/*: convert to
> > pci_register_driver
> >
> >
> > convert from pci_module_init to pci_register_driver
> > (from:http://kerneljanitors.org/TODO).
> >
> > Signed-off-by: Christophe Lucas <c.lucas@ifrance.com>
> > Signed-off-by: Domen Puncer <domen@coderock.org>
> > ---
> >
> >
> > kj-domen/drivers/scsi/aacraid/linit.c | 2 +-
> > 1 files changed, 1 insertion(+), 1 deletion(-)
> >
> > diff -puN
> >
drivers/scsi/aacraid/linit.c~pci_register_driver-drivers_scsi_aacraid
> > drivers/scsi/aacraid/linit.c
> > ---
> >
>
kj/drivers/scsi/aacraid/linit.c~pci_register_driver-drivers_scsi_aacraid
> > 2005-03-05 16:12:51.000000000 +0100
> > +++ kj-domen/drivers/scsi/aacraid/linit.c 2005-03-05
> > 16:12:51.000000000 +0100
> > @@ -690,7 +690,7 @@ static int __init aac_init(void)
> > printk(KERN_INFO "Red Hat/Adaptec aacraid driver (%s %s)\n",
> > AAC_DRIVER_VERSION, AAC_DRIVER_BUILD_DATE);
> >
> > - error = pci_module_init(&aac_pci_driver);
> > + error = pci_register_driver(&aac_pci_driver);
> > if (error)
> > return error;
> >
> > _
> > -
> > To unsubscribe from this list: send the line "unsubscribe
linux-scsi"
> in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [patch 06/11] drivers/scsi/aacraid/*: convert to pci_register_driver
2005-03-15 17:59 [patch 06/11] drivers/scsi/aacraid/*: convert to pci_register_driver Salyzyn, Mark
@ 2005-03-15 20:17 ` Domen Puncer
0 siblings, 0 replies; 7+ messages in thread
From: Domen Puncer @ 2005-03-15 20:17 UTC (permalink / raw)
To: Salyzyn, Mark; +Cc: James.Bottomley, linux-scsi, c.lucas
On 15/03/05 12:59 -0500, Salyzyn, Mark wrote:
> FC3 != kernel.org, and the problem may not exist in latest tree. The
> code for pci_module_init used to do a return (ret < 0) ? ret : 0.
>
> The problem is then a 'transition' issue, as patches that appear here
> can and will be used for kernel revisions a few back. By changing the
> aacraid driver to check for < 0 rather than != 0 we improve reliability.
> I have discovered that by doing so, the driver in the Adaptec Branch
> taking this patch works fine all the way back early 2.4 trees.
>
Thanks for clearing that up.
Forgot that scsi is 2.4 compatible. And I have a note to drop
pci_register_driver patches for it. Sorry for all the noise.
So, here's a new patch, if someone wants it; i won't be resending :-)
Use pci_register_driver instead of pci_module_init (old API).
Signed-off-by: Domen Puncer <domen@coderock.org>
--- ./drivers/scsi/aacraid/linit.c.orig 2005-03-15 21:05:53.000000000 +0100
+++ ./drivers/scsi/aacraid/linit.c 2005-03-15 21:06:59.000000000 +0100
@@ -686,12 +686,12 @@ static struct pci_driver aac_pci_driver
static int __init aac_init(void)
{
int error;
-
+
printk(KERN_INFO "Red Hat/Adaptec aacraid driver (%s %s)\n",
AAC_DRIVER_VERSION, AAC_DRIVER_BUILD_DATE);
- error = pci_module_init(&aac_pci_driver);
- if (error)
+ error = pci_register_driver(&aac_pci_driver);
+ if (error < 0)
return error;
aac_cfg_major = register_chrdev( 0, "aac", &aac_cfg_fops);
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [patch 06/11] drivers/scsi/aacraid/*: convert to pci_register_driver
@ 2005-03-15 15:59 Salyzyn, Mark
2005-03-15 17:45 ` Domen Puncer
0 siblings, 1 reply; 7+ messages in thread
From: Salyzyn, Mark @ 2005-03-15 15:59 UTC (permalink / raw)
To: Domen Puncer; +Cc: James.Bottomley, linux-scsi, c.lucas
We have tested and seen a positive number being returned on late model
distributions (FC3)
Sincerely -- Mark Salyzyn
-----Original Message-----
From: Domen Puncer [mailto:domen@coderock.org]
Sent: Tuesday, March 15, 2005 10:57 AM
To: Salyzyn, Mark
Cc: James.Bottomley@SteelEye.com; linux-scsi@vger.kernel.org;
c.lucas@ifrance.com
Subject: Re: [patch 06/11] drivers/scsi/aacraid/*: convert to
pci_register_driver
On 15/03/05 08:38 -0500, Salyzyn, Mark wrote:
> I have to reject this change since pci_module_init() has a different
> return code than pci_register_driver().
pci.h: #define pci_module_init pci_register_driver
pci-driver.c: pci_register_driver:
"Returns a negative value on error, otherwise 0."
So... since it can't return positive number, these conditions are the
same.
>
> The patch should look like:
>
> - error = pci_module_init(&aac_pci_driver);
> + error = pci_register_driver(&aac_pci_driver);
> - if (error)
> + if (error < 0)
> return error;
>
> Sincerely -- Mark Salyzyn
>
> -----Original Message-----
> From: linux-scsi-owner@vger.kernel.org
> [mailto:linux-scsi-owner@vger.kernel.org] On Behalf Of
> domen@coderock.org
> Sent: Sunday, March 06, 2005 5:27 PM
> To: James.Bottomley@SteelEye.com
> Cc: linux-scsi@vger.kernel.org; domen@coderock.org;
c.lucas@ifrance.com
> Subject: [patch 06/11] drivers/scsi/aacraid/*: convert to
> pci_register_driver
>
>
> convert from pci_module_init to pci_register_driver
> (from:http://kerneljanitors.org/TODO).
>
> Signed-off-by: Christophe Lucas <c.lucas@ifrance.com>
> Signed-off-by: Domen Puncer <domen@coderock.org>
> ---
>
>
> kj-domen/drivers/scsi/aacraid/linit.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN
> drivers/scsi/aacraid/linit.c~pci_register_driver-drivers_scsi_aacraid
> drivers/scsi/aacraid/linit.c
> ---
>
kj/drivers/scsi/aacraid/linit.c~pci_register_driver-drivers_scsi_aacraid
> 2005-03-05 16:12:51.000000000 +0100
> +++ kj-domen/drivers/scsi/aacraid/linit.c 2005-03-05
> 16:12:51.000000000 +0100
> @@ -690,7 +690,7 @@ static int __init aac_init(void)
> printk(KERN_INFO "Red Hat/Adaptec aacraid driver (%s %s)\n",
> AAC_DRIVER_VERSION, AAC_DRIVER_BUILD_DATE);
>
> - error = pci_module_init(&aac_pci_driver);
> + error = pci_register_driver(&aac_pci_driver);
> if (error)
> return error;
>
> _
> -
> To unsubscribe from this list: send the line "unsubscribe linux-scsi"
in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch 06/11] drivers/scsi/aacraid/*: convert to pci_register_driver
2005-03-15 15:59 Salyzyn, Mark
@ 2005-03-15 17:45 ` Domen Puncer
0 siblings, 0 replies; 7+ messages in thread
From: Domen Puncer @ 2005-03-15 17:45 UTC (permalink / raw)
To: Salyzyn, Mark; +Cc: James.Bottomley, linux-scsi, c.lucas
On 15/03/05 10:59 -0500, Salyzyn, Mark wrote:
> We have tested and seen a positive number being returned on late model
> distributions (FC3)
Function tree from 2.6.11-bk9:
pci_register_driver
driver_register
bus_add_driver
kobject_set_name - ok
kobject_register
kobject_add
create_dir
sysfs_create_dir
create_dir (different from above)
sysfs_create
init (init_dir from sysfs/dir.c) - ok
sysfs_make_dirent - ok
populate_dir
sysfs_create_file
sysfs_add_file
sysfs_make_dirent - ok
Seems ok to me. Am I missing something?
How about a "if (error > 0) dump_stack()" to find the offender?
>
> Sincerely -- Mark Salyzyn
>
> -----Original Message-----
> From: Domen Puncer [mailto:domen@coderock.org]
> Sent: Tuesday, March 15, 2005 10:57 AM
> To: Salyzyn, Mark
> Cc: James.Bottomley@SteelEye.com; linux-scsi@vger.kernel.org;
> c.lucas@ifrance.com
> Subject: Re: [patch 06/11] drivers/scsi/aacraid/*: convert to
> pci_register_driver
>
> On 15/03/05 08:38 -0500, Salyzyn, Mark wrote:
> > I have to reject this change since pci_module_init() has a different
> > return code than pci_register_driver().
>
> pci.h: #define pci_module_init pci_register_driver
>
> pci-driver.c: pci_register_driver:
> "Returns a negative value on error, otherwise 0."
>
> So... since it can't return positive number, these conditions are the
> same.
>
>
> >
> > The patch should look like:
> >
> > - error = pci_module_init(&aac_pci_driver);
> > + error = pci_register_driver(&aac_pci_driver);
> > - if (error)
> > + if (error < 0)
> > return error;
> >
> > Sincerely -- Mark Salyzyn
> >
> > -----Original Message-----
> > From: linux-scsi-owner@vger.kernel.org
> > [mailto:linux-scsi-owner@vger.kernel.org] On Behalf Of
> > domen@coderock.org
> > Sent: Sunday, March 06, 2005 5:27 PM
> > To: James.Bottomley@SteelEye.com
> > Cc: linux-scsi@vger.kernel.org; domen@coderock.org;
> c.lucas@ifrance.com
> > Subject: [patch 06/11] drivers/scsi/aacraid/*: convert to
> > pci_register_driver
> >
> >
> > convert from pci_module_init to pci_register_driver
> > (from:http://kerneljanitors.org/TODO).
> >
> > Signed-off-by: Christophe Lucas <c.lucas@ifrance.com>
> > Signed-off-by: Domen Puncer <domen@coderock.org>
> > ---
> >
> >
> > kj-domen/drivers/scsi/aacraid/linit.c | 2 +-
> > 1 files changed, 1 insertion(+), 1 deletion(-)
> >
> > diff -puN
> > drivers/scsi/aacraid/linit.c~pci_register_driver-drivers_scsi_aacraid
> > drivers/scsi/aacraid/linit.c
> > ---
> >
> kj/drivers/scsi/aacraid/linit.c~pci_register_driver-drivers_scsi_aacraid
> > 2005-03-05 16:12:51.000000000 +0100
> > +++ kj-domen/drivers/scsi/aacraid/linit.c 2005-03-05
> > 16:12:51.000000000 +0100
> > @@ -690,7 +690,7 @@ static int __init aac_init(void)
> > printk(KERN_INFO "Red Hat/Adaptec aacraid driver (%s %s)\n",
> > AAC_DRIVER_VERSION, AAC_DRIVER_BUILD_DATE);
> >
> > - error = pci_module_init(&aac_pci_driver);
> > + error = pci_register_driver(&aac_pci_driver);
> > if (error)
> > return error;
> >
> > _
> > -
> > To unsubscribe from this list: send the line "unsubscribe linux-scsi"
> in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [patch 06/11] drivers/scsi/aacraid/*: convert to pci_register_driver
@ 2005-03-15 13:38 Salyzyn, Mark
2005-03-15 15:57 ` Domen Puncer
0 siblings, 1 reply; 7+ messages in thread
From: Salyzyn, Mark @ 2005-03-15 13:38 UTC (permalink / raw)
To: domen, James.Bottomley; +Cc: linux-scsi, c.lucas
I have to reject this change since pci_module_init() has a different
return code than pci_register_driver().
The patch should look like:
- error = pci_module_init(&aac_pci_driver);
+ error = pci_register_driver(&aac_pci_driver);
- if (error)
+ if (error < 0)
return error;
Sincerely -- Mark Salyzyn
-----Original Message-----
From: linux-scsi-owner@vger.kernel.org
[mailto:linux-scsi-owner@vger.kernel.org] On Behalf Of
domen@coderock.org
Sent: Sunday, March 06, 2005 5:27 PM
To: James.Bottomley@SteelEye.com
Cc: linux-scsi@vger.kernel.org; domen@coderock.org; c.lucas@ifrance.com
Subject: [patch 06/11] drivers/scsi/aacraid/*: convert to
pci_register_driver
convert from pci_module_init to pci_register_driver
(from:http://kerneljanitors.org/TODO).
Signed-off-by: Christophe Lucas <c.lucas@ifrance.com>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
kj-domen/drivers/scsi/aacraid/linit.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -puN
drivers/scsi/aacraid/linit.c~pci_register_driver-drivers_scsi_aacraid
drivers/scsi/aacraid/linit.c
---
kj/drivers/scsi/aacraid/linit.c~pci_register_driver-drivers_scsi_aacraid
2005-03-05 16:12:51.000000000 +0100
+++ kj-domen/drivers/scsi/aacraid/linit.c 2005-03-05
16:12:51.000000000 +0100
@@ -690,7 +690,7 @@ static int __init aac_init(void)
printk(KERN_INFO "Red Hat/Adaptec aacraid driver (%s %s)\n",
AAC_DRIVER_VERSION, AAC_DRIVER_BUILD_DATE);
- error = pci_module_init(&aac_pci_driver);
+ error = pci_register_driver(&aac_pci_driver);
if (error)
return error;
_
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch 06/11] drivers/scsi/aacraid/*: convert to pci_register_driver
2005-03-15 13:38 Salyzyn, Mark
@ 2005-03-15 15:57 ` Domen Puncer
0 siblings, 0 replies; 7+ messages in thread
From: Domen Puncer @ 2005-03-15 15:57 UTC (permalink / raw)
To: Salyzyn, Mark; +Cc: James.Bottomley, linux-scsi, c.lucas
On 15/03/05 08:38 -0500, Salyzyn, Mark wrote:
> I have to reject this change since pci_module_init() has a different
> return code than pci_register_driver().
pci.h: #define pci_module_init pci_register_driver
pci-driver.c: pci_register_driver:
"Returns a negative value on error, otherwise 0."
So... since it can't return positive number, these conditions are the same.
>
> The patch should look like:
>
> - error = pci_module_init(&aac_pci_driver);
> + error = pci_register_driver(&aac_pci_driver);
> - if (error)
> + if (error < 0)
> return error;
>
> Sincerely -- Mark Salyzyn
>
> -----Original Message-----
> From: linux-scsi-owner@vger.kernel.org
> [mailto:linux-scsi-owner@vger.kernel.org] On Behalf Of
> domen@coderock.org
> Sent: Sunday, March 06, 2005 5:27 PM
> To: James.Bottomley@SteelEye.com
> Cc: linux-scsi@vger.kernel.org; domen@coderock.org; c.lucas@ifrance.com
> Subject: [patch 06/11] drivers/scsi/aacraid/*: convert to
> pci_register_driver
>
>
> convert from pci_module_init to pci_register_driver
> (from:http://kerneljanitors.org/TODO).
>
> Signed-off-by: Christophe Lucas <c.lucas@ifrance.com>
> Signed-off-by: Domen Puncer <domen@coderock.org>
> ---
>
>
> kj-domen/drivers/scsi/aacraid/linit.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN
> drivers/scsi/aacraid/linit.c~pci_register_driver-drivers_scsi_aacraid
> drivers/scsi/aacraid/linit.c
> ---
> kj/drivers/scsi/aacraid/linit.c~pci_register_driver-drivers_scsi_aacraid
> 2005-03-05 16:12:51.000000000 +0100
> +++ kj-domen/drivers/scsi/aacraid/linit.c 2005-03-05
> 16:12:51.000000000 +0100
> @@ -690,7 +690,7 @@ static int __init aac_init(void)
> printk(KERN_INFO "Red Hat/Adaptec aacraid driver (%s %s)\n",
> AAC_DRIVER_VERSION, AAC_DRIVER_BUILD_DATE);
>
> - error = pci_module_init(&aac_pci_driver);
> + error = pci_register_driver(&aac_pci_driver);
> if (error)
> return error;
>
> _
> -
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* [patch 06/11] drivers/scsi/aacraid/*: convert to pci_register_driver
@ 2005-03-06 22:27 domen
0 siblings, 0 replies; 7+ messages in thread
From: domen @ 2005-03-06 22:27 UTC (permalink / raw)
To: James.Bottomley; +Cc: linux-scsi, domen, c.lucas
convert from pci_module_init to pci_register_driver
(from:http://kerneljanitors.org/TODO).
Signed-off-by: Christophe Lucas <c.lucas@ifrance.com>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
kj-domen/drivers/scsi/aacraid/linit.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/scsi/aacraid/linit.c~pci_register_driver-drivers_scsi_aacraid drivers/scsi/aacraid/linit.c
--- kj/drivers/scsi/aacraid/linit.c~pci_register_driver-drivers_scsi_aacraid 2005-03-05 16:12:51.000000000 +0100
+++ kj-domen/drivers/scsi/aacraid/linit.c 2005-03-05 16:12:51.000000000 +0100
@@ -690,7 +690,7 @@ static int __init aac_init(void)
printk(KERN_INFO "Red Hat/Adaptec aacraid driver (%s %s)\n",
AAC_DRIVER_VERSION, AAC_DRIVER_BUILD_DATE);
- error = pci_module_init(&aac_pci_driver);
+ error = pci_register_driver(&aac_pci_driver);
if (error)
return error;
_
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2005-03-15 20:17 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-15 17:59 [patch 06/11] drivers/scsi/aacraid/*: convert to pci_register_driver Salyzyn, Mark
2005-03-15 20:17 ` Domen Puncer
-- strict thread matches above, loose matches on Subject: below --
2005-03-15 15:59 Salyzyn, Mark
2005-03-15 17:45 ` Domen Puncer
2005-03-15 13:38 Salyzyn, Mark
2005-03-15 15:57 ` Domen Puncer
2005-03-06 22:27 domen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox