From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>, Erich Chen <erich@areca.com.tw>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: 2.6.11-mm4: drivers/scsi/arcmsr/arcmsr.c: enormous stack usage
Date: Sat, 19 Mar 2005 14:39:52 +0100 [thread overview]
Message-ID: <20050319133951.GK3143@stusta.de> (raw)
In-Reply-To: <20050316040654.62881834.akpm@osdl.org>
On Wed, Mar 16, 2005 at 04:06:54AM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.11-mm3:
>...
> +areca-raid-linux-scsi-driver.patch
>
> Updated version of this driver.
>...
<-- snip -->
...
static int arcmsr_iop_ioctlcmd(PACB pACB, int ioctl_cmd, void *arg)
{
...
uint8_t tmpQbuffer[1032];
...
uint8_t tmpuserbuffer[1032];
...
}
...
<-- snip -->
1kB allocations from the stack aren't a good idea considering that you
might have only a 4kB stack altogether.
Running "make checkstack" after compiling the kernel helps you finding
such problems.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next parent reply other threads:[~2005-03-19 13:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20050316040654.62881834.akpm@osdl.org>
2005-03-19 13:39 ` Adrian Bunk [this message]
[not found] ` <002c01c52df4$37620cd0$9300a8c0@erich2003>
2005-03-22 15:56 ` 2.6.11-mm4: drivers/scsi/arcmsr/arcmsr.c: enormous stack usage Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050319133951.GK3143@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=erich@areca.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox