public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 11/19] drivers/scsi/gdth: Use the DMA_{64,32}BIT_MASK constants
@ 2005-02-20 17:05 Tobias Klauser
  2005-03-20 12:52 ` [UPDATE PATCH 11/19] drivers/scsi/gdth: Use the DMA_{64, 32}BIT_MASK constants Tobias Klauser
  0 siblings, 1 reply; 2+ messages in thread
From: Tobias Klauser @ 2005-02-20 17:05 UTC (permalink / raw)
  To: kernel-janitors; +Cc: linux-scsi

Hello,

Description: Use the DMA_{64,32}BIT_MASK constants from dma-mapping.h
when calling pci_set_dma_mask() or pci_set_consistent_dma_mask()
See http://marc.theaimsgroup.com/?t=108001993000001&r=1&w=2 for details

Signed-off-by: Tobias Klauser <tklauser@nuerscht.ch>

--- linux-2.6.11-rc4.orig/drivers/scsi/gdth.c	2005-02-13 17:13:06.000000000 +0100
+++ linux-2.6.11-rc4/drivers/scsi/gdth.c	2005-02-16 21:22:37.000000000 +0100
@@ -4529,15 +4529,15 @@ int __init gdth_detect(Scsi_Host_Templat
             if (!(ha->cache_feat & ha->raw_feat & ha->screen_feat &GDT_64BIT)||
                 /* 64-bit DMA only supported from FW >= x.43 */
                 (!ha->dma64_support)) {
-                if (pci_set_dma_mask(pcistr[ctr].pdev, 0xffffffff)) {
+                if (pci_set_dma_mask(pcistr[ctr].pdev, DMA_32BIT_MASK)) {
                     printk(KERN_WARNING "GDT-PCI %d: Unable to set 32-bit DMA\n", hanum);
                     err = TRUE;
                 }
             } else {
                 shp->max_cmd_len = 16;
-                if (!pci_set_dma_mask(pcistr[ctr].pdev, 0xffffffffffffffffULL)) {
+                if (!pci_set_dma_mask(pcistr[ctr].pdev, DMA_64BIT_MASK)) {
                     printk("GDT-PCI %d: 64-bit DMA enabled\n", hanum);
-                } else if (pci_set_dma_mask(pcistr[ctr].pdev, 0xffffffff)) {
+                } else if (pci_set_dma_mask(pcistr[ctr].pdev, DMA_32BIT_MASK)) {
                     printk(KERN_WARNING "GDT-PCI %d: Unable to set 64/32-bit DMA\n", hanum);
                     err = TRUE;
                 }

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [UPDATE PATCH 11/19] drivers/scsi/gdth: Use the DMA_{64, 32}BIT_MASK constants
  2005-02-20 17:05 [PATCH 11/19] drivers/scsi/gdth: Use the DMA_{64,32}BIT_MASK constants Tobias Klauser
@ 2005-03-20 12:52 ` Tobias Klauser
  0 siblings, 0 replies; 2+ messages in thread
From: Tobias Klauser @ 2005-03-20 12:52 UTC (permalink / raw)
  To: kernel-janitors; +Cc: achim_leubner, linux-scsi

The previous patch did not compile cleanly on all architectures so
here's a fixed one.

Use the DMA_{64,32}BIT_MASK constants from dma-mapping.h when calling
pci_set_dma_mask() or pci_set_consistent_dma_mask()
This patch includes dma-mapping.h explicitly because it caused errors
on some architectures otherwise.
See http://marc.theaimsgroup.com/?t=108001993000001&r=1&w=2 for details

Signed-off-by: Tobias Klauser <tklauser@nuerscht.ch>

--- linux-2.6.11.orig/drivers/scsi/gdth.c	2005-03-02 12:50:38.000000000 +0100
+++ linux-2.6.11/drivers/scsi/gdth.c	2005-03-20 13:50:36.000000000 +0100
@@ -402,6 +402,7 @@
 #include <linux/blkdev.h>
 #else
 #include <linux/blk.h>
+#include <linux/dma-mapping.h>
 #include "sd.h"
 #endif
 
@@ -4529,15 +4530,15 @@ int __init gdth_detect(Scsi_Host_Templat
             if (!(ha->cache_feat & ha->raw_feat & ha->screen_feat &GDT_64BIT)||
                 /* 64-bit DMA only supported from FW >= x.43 */
                 (!ha->dma64_support)) {
-                if (pci_set_dma_mask(pcistr[ctr].pdev, 0xffffffff)) {
+                if (pci_set_dma_mask(pcistr[ctr].pdev, DMA_32BIT_MASK)) {
                     printk(KERN_WARNING "GDT-PCI %d: Unable to set 32-bit DMA\n", hanum);
                     err = TRUE;
                 }
             } else {
                 shp->max_cmd_len = 16;
-                if (!pci_set_dma_mask(pcistr[ctr].pdev, 0xffffffffffffffffULL)) {
+                if (!pci_set_dma_mask(pcistr[ctr].pdev, DMA_64BIT_MASK)) {
                     printk("GDT-PCI %d: 64-bit DMA enabled\n", hanum);
-                } else if (pci_set_dma_mask(pcistr[ctr].pdev, 0xffffffff)) {
+                } else if (pci_set_dma_mask(pcistr[ctr].pdev, DMA_32BIT_MASK)) {
                     printk(KERN_WARNING "GDT-PCI %d: Unable to set 64/32-bit DMA\n", hanum);
                     err = TRUE;
                 }

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-03-20 12:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-20 17:05 [PATCH 11/19] drivers/scsi/gdth: Use the DMA_{64,32}BIT_MASK constants Tobias Klauser
2005-03-20 12:52 ` [UPDATE PATCH 11/19] drivers/scsi/gdth: Use the DMA_{64, 32}BIT_MASK constants Tobias Klauser

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox