* [PATCH 14/19] drivers/scsi/megaraid/megaraid_mbox: Use the DMA_{64,32}BIT_MASK constants
@ 2005-02-20 17:08 Tobias Klauser
2005-03-20 13:13 ` [UPDATE PATCH 14/19] drivers/scsi/megaraid/megaraid_mbox: Use the DMA_{64, 32}BIT_MASK constants Tobias Klauser
0 siblings, 1 reply; 2+ messages in thread
From: Tobias Klauser @ 2005-02-20 17:08 UTC (permalink / raw)
To: kernel-janitors; +Cc: linux-scsi
Hello,
Description: Use the DMA_{64,32}BIT_MASK constants from dma-mapping.h
when calling pci_set_dma_mask() or pci_set_consistent_dma_mask()
See http://marc.theaimsgroup.com/?t=108001993000001&r=1&w=2 for details
Signed-off-by: Tobias Klauser <tklauser@nuerscht.ch>
--- linux-2.6.11-rc4.orig/drivers/scsi/megaraid/megaraid_mbox.c 2005-02-13 17:13:06.000000000 +0100
+++ linux-2.6.11-rc4/drivers/scsi/megaraid/megaraid_mbox.c 2005-02-16 21:29:18.000000000 +0100
@@ -619,7 +619,7 @@ megaraid_probe_one(struct pci_dev *pdev,
// Setup the default DMA mask. This would be changed later on
// depending on hardware capabilities
- if (pci_set_dma_mask(adapter->pdev, 0xFFFFFFFF) != 0) {
+ if (pci_set_dma_mask(adapter->pdev, DMA_32BIT_MASK) != 0) {
con_log(CL_ANN, (KERN_WARNING
"megaraid: pci_set_dma_mask failed:%d\n", __LINE__));
@@ -1031,7 +1031,7 @@ megaraid_init_mbox(adapter_t *adapter)
// Set the DMA mask to 64-bit. All supported controllers as capable of
// DMA in this range
- if (pci_set_dma_mask(adapter->pdev, 0xFFFFFFFFFFFFFFFFULL) != 0) {
+ if (pci_set_dma_mask(adapter->pdev, DMA_64BIT_MASK) != 0) {
con_log(CL_ANN, (KERN_WARNING
"megaraid: could not set DMA mask for 64-bit.\n"));
^ permalink raw reply [flat|nested] 2+ messages in thread
* [UPDATE PATCH 14/19] drivers/scsi/megaraid/megaraid_mbox: Use the DMA_{64, 32}BIT_MASK constants
2005-02-20 17:08 [PATCH 14/19] drivers/scsi/megaraid/megaraid_mbox: Use the DMA_{64,32}BIT_MASK constants Tobias Klauser
@ 2005-03-20 13:13 ` Tobias Klauser
0 siblings, 0 replies; 2+ messages in thread
From: Tobias Klauser @ 2005-03-20 13:13 UTC (permalink / raw)
To: kernel-janitors; +Cc: linux-scsi
The previous patch did not compile cleanly on all architectures so
here's a fixed one.
Use the DMA_{64,32}BIT_MASK constants from dma-mapping.h when calling
pci_set_dma_mask() or pci_set_consistent_dma_mask()
This patch includes dma-mapping.h explicitly because it caused errors
on some architectures otherwise.
See http://marc.theaimsgroup.com/?t=108001993000001&r=1&w=2 for details
Signed-off-by: Tobias Klauser <tklauser@nuerscht.ch>
--- linux-2.6.11.orig/drivers/scsi/megaraid/megaraid_mbox.c 2005-03-02 12:50:37.000000000 +0100
+++ linux-2.6.11/drivers/scsi/megaraid/megaraid_mbox.c 2005-03-20 13:27:54.000000000 +0100
@@ -69,6 +69,7 @@
* For history of changes, see Documentation/ChangeLog.megaraid
*/
+#include <linux/dma-mapping.h>
#include "megaraid_mbox.h"
static int megaraid_init(void);
@@ -619,7 +620,7 @@ megaraid_probe_one(struct pci_dev *pdev,
// Setup the default DMA mask. This would be changed later on
// depending on hardware capabilities
- if (pci_set_dma_mask(adapter->pdev, 0xFFFFFFFF) != 0) {
+ if (pci_set_dma_mask(adapter->pdev, DMA_32BIT_MASK) != 0) {
con_log(CL_ANN, (KERN_WARNING
"megaraid: pci_set_dma_mask failed:%d\n", __LINE__));
@@ -1031,7 +1032,7 @@ megaraid_init_mbox(adapter_t *adapter)
// Set the DMA mask to 64-bit. All supported controllers as capable of
// DMA in this range
- if (pci_set_dma_mask(adapter->pdev, 0xFFFFFFFFFFFFFFFFULL) != 0) {
+ if (pci_set_dma_mask(adapter->pdev, DMA_64BIT_MASK) != 0) {
con_log(CL_ANN, (KERN_WARNING
"megaraid: could not set DMA mask for 64-bit.\n"));
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-03-20 13:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-20 17:08 [PATCH 14/19] drivers/scsi/megaraid/megaraid_mbox: Use the DMA_{64,32}BIT_MASK constants Tobias Klauser
2005-03-20 13:13 ` [UPDATE PATCH 14/19] drivers/scsi/megaraid/megaraid_mbox: Use the DMA_{64, 32}BIT_MASK constants Tobias Klauser
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox