* [2.6 patch] drivers/scsi/osst.c: remove unused code
@ 2005-03-22 21:59 Adrian Bunk
2005-03-23 12:16 ` Willem Riede
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2005-03-22 21:59 UTC (permalink / raw)
To: osst; +Cc: osst-users, James.Bottomley, linux-scsi, linux-kernel
Thanks to both the Coverity checker and GNU gcc, it was found that this
variable is completely unused.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.12-rc1-mm1-full/drivers/scsi/osst.c.old 2005-03-22 21:04:36.000000000 +0100
+++ linux-2.6.12-rc1-mm1-full/drivers/scsi/osst.c 2005-03-22 22:09:32.000000000 +0100
@@ -4770,9 +4770,6 @@ static int os_scsi_tape_close(struct ino
{
int result = 0;
struct osst_tape * STp = filp->private_data;
- struct scsi_request * SRpnt = NULL;
-
- if (SRpnt) scsi_release_request(SRpnt);
if (STp->door_locked == ST_LOCKED_AUTO)
do_door_lock(STp, 0);
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [2.6 patch] drivers/scsi/osst.c: remove unused code
2005-03-22 21:59 [2.6 patch] drivers/scsi/osst.c: remove unused code Adrian Bunk
@ 2005-03-23 12:16 ` Willem Riede
0 siblings, 0 replies; 2+ messages in thread
From: Willem Riede @ 2005-03-23 12:16 UTC (permalink / raw)
To: Adrian Bunk; +Cc: osst-users, James.Bottomley, linux-scsi, linux-kernel
On 03/22/2005 04:59:48 PM, Adrian Bunk wrote:
> Thanks to both the Coverity checker and GNU gcc, it was found that this
> variable is completely unused.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
And it is so obvious when your attention is drawn to it.
The code that did use it moved to os_scsi_tape_flush() recently.
James, could you make this change in BK too, please?
Signed-off-by: Willem Riede <osst@riede.org>
> --- linux-2.6.12-rc1-mm1-full/drivers/scsi/osst.c.old 2005-03-22 21:04:36.000000000 +0100
> +++ linux-2.6.12-rc1-mm1-full/drivers/scsi/osst.c 2005-03-22 22:09:32.000000000 +0100
> @@ -4770,9 +4770,6 @@ static int os_scsi_tape_close(struct ino
> {
> int result = 0;
> struct osst_tape * STp = filp->private_data;
> - struct scsi_request * SRpnt = NULL;
> -
> - if (SRpnt) scsi_release_request(SRpnt);
>
> if (STp->door_locked == ST_LOCKED_AUTO)
> do_door_lock(STp, 0);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-03-23 12:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-22 21:59 [2.6 patch] drivers/scsi/osst.c: remove unused code Adrian Bunk
2005-03-23 12:16 ` Willem Riede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox