From: Christoph Hellwig <hch@infradead.org>
To: "Moore, Eric Dean" <Eric.Moore@lsil.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] - MPT FUSION - SPLITTING SCSI HOST DRIVERS
Date: Sat, 26 Mar 2005 11:21:08 +0000 [thread overview]
Message-ID: <20050326112108.GA25751@infradead.org> (raw)
In-Reply-To: <91888D455306F94EBD4D168954A9457C01B7055E@nacos172.co.lsil.com>
I took a quick look an a here's a few comments:
- I don't think renaming mptscsih.c to mpt_core.c makes sense.
the new name is confusing at best, and keeping the old name allows
to keep SCCS history aswell. That means the new SPI stub driver should
be called mptspi or something like that.
- please don't link mpt_core.o into both mptfch.ko and mptscsih.ko but
make it a module of it's own
- the new driver shoild use module_param, not MODULE_PARM
- why does the fc driver set ioc->spi_data.mpt_pq_filter?
- no need to forward-declare the module_init/module_exit handlers
next prev parent reply other threads:[~2005-03-26 11:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-24 23:56 [PATCH] - MPT FUSION - SPLITTING SCSI HOST DRIVERS Moore, Eric Dean
2005-03-26 11:21 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-03-28 19:34 Moore, Eric Dean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050326112108.GA25751@infradead.org \
--to=hch@infradead.org \
--cc=Eric.Moore@lsil.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox