From: Greg KH <greg@kroah.com>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: James Bottomley <James.Bottomley@SteelEye.com>,
Patrick Mansfield <patmans@us.ibm.com>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] 2/2 Use bus dev_attrs to create scsi_device attributes
Date: Wed, 6 Apr 2005 13:22:13 -0700 [thread overview]
Message-ID: <20050406202213.GB31699@kroah.com> (raw)
In-Reply-To: <20050330180702.GA4654@vrfy.org>
On Wed, Mar 30, 2005 at 08:07:02PM +0200, Kay Sievers wrote:
> On Tue, Mar 29, 2005 at 08:20:43PM -0800, Greg KH wrote:
> > On Wed, Mar 30, 2005 at 05:15:55AM +0200, Kay Sievers wrote:
> > > /**
> > > + * sysfs_chmod_file - update the modified mode value on an object attribute.
> > > + * @kobj: object we're acting for.
> > > + * @mode: file permissions.
> > > + *
> > > + */
> > > +int sysfs_chmod_file(struct kobject *kobj, const struct attribute *attr)
> >
> > Your documentation doesn't match up with your function arguments :)
>
> Bah, I tried both versions. :)
>
> > Shouldn't you want an extra mode variable? Makes it easier to override
> > than remembering to change the mode in the attribute before calling the
> > function.
>
> If that's better, sure. Here is a new patch.
Looks good, applied to my tree.
thanks,
greg k-h
next prev parent reply other threads:[~2005-04-06 20:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-02 19:44 [PATCH] 0/2 use sysfs bus dev_attrs for scsi_device attributes Patrick Mansfield
2005-03-02 19:45 ` [PATCH] 1/2 remove attr_changed_internally Patrick Mansfield
2005-03-02 19:46 ` [PATCH] 2/2 Use bus dev_attrs to create scsi_device attributes Patrick Mansfield
2005-03-16 22:45 ` Patrick Mansfield
2005-03-17 14:53 ` James Bottomley
2005-03-17 17:08 ` Greg KH
2005-03-30 3:15 ` Kay Sievers
2005-03-30 4:20 ` Greg KH
2005-03-30 18:07 ` Kay Sievers
2005-04-06 20:22 ` Greg KH [this message]
2005-03-30 18:32 ` Kay Sievers
2005-03-30 21:44 ` Patrick Mansfield
2005-03-30 22:12 ` Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050406202213.GB31699@kroah.com \
--to=greg@kroah.com \
--cc=James.Bottomley@SteelEye.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-scsi@vger.kernel.org \
--cc=patmans@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox