From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH] 2/2 Use bus dev_attrs to create scsi_device attributes Date: Wed, 6 Apr 2005 13:22:13 -0700 Message-ID: <20050406202213.GB31699@kroah.com> References: <20050302194432.GA9743@us.ibm.com> <20050302194553.GA9776@us.ibm.com> <20050302194647.GB9776@us.ibm.com> <20050316224551.GA21918@us.ibm.com> <1111071201.5994.4.camel@mulgrave> <20050317170853.GA3006@kroah.com> <20050330031555.GA18871@vrfy.org> <20050330042043.GA9002@kroah.com> <20050330180702.GA4654@vrfy.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail.kroah.org ([69.55.234.183]:48546 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S262310AbVDFUWj (ORCPT ); Wed, 6 Apr 2005 16:22:39 -0400 Content-Disposition: inline In-Reply-To: <20050330180702.GA4654@vrfy.org> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Kay Sievers Cc: James Bottomley , Patrick Mansfield , SCSI Mailing List On Wed, Mar 30, 2005 at 08:07:02PM +0200, Kay Sievers wrote: > On Tue, Mar 29, 2005 at 08:20:43PM -0800, Greg KH wrote: > > On Wed, Mar 30, 2005 at 05:15:55AM +0200, Kay Sievers wrote: > > > /** > > > + * sysfs_chmod_file - update the modified mode value on an object attribute. > > > + * @kobj: object we're acting for. > > > + * @mode: file permissions. > > > + * > > > + */ > > > +int sysfs_chmod_file(struct kobject *kobj, const struct attribute *attr) > > > > Your documentation doesn't match up with your function arguments :) > > Bah, I tried both versions. :) > > > Shouldn't you want an extra mode variable? Makes it easier to override > > than remembering to change the mode in the attribute before calling the > > function. > > If that's better, sure. Here is a new patch. Looks good, applied to my tree. thanks, greg k-h