From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] Use proper seq_file api for /proc/scsi/scsi Date: Fri, 8 Apr 2005 08:56:43 +0100 Message-ID: <20050408075643.GA5514@infradead.org> References: <42550173.1040503@suse.de> <20050407103123.GB9586@infradead.org> <425517B3.2010702@suse.de> <20050407112412.GA12072@infradead.org> <20050408072345.GA1018765@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:56245 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S262748AbVDHH4u (ORCPT ); Fri, 8 Apr 2005 03:56:50 -0400 Content-Disposition: inline In-Reply-To: <20050408072345.GA1018765@sgi.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Jeremy Higdon Cc: Christoph Hellwig , Hannes Reinecke , Linux Kernel , SCSI Mailing List On Fri, Apr 08, 2005 at 12:23:46AM -0700, Jeremy Higdon wrote: > > It works for those setups that already worked with 2.4.x, aka only a few > > luns. > > Even if it's deprecated, wouldn't it be good to fix it as long as > it's there, unless it hurts something else? Or at least fix the > out of memory error, even if it doesn't display all the luns? What other error would you return? I don't particularly care what exact error code to return, but putting in Hannes patch would be a bad idea because it a) poke deep into driver model internals, and we absolutely want to avoid that b) sets a bad precedence that we'll continue adding features to deprecated interface and thus encurage people to contiue using it. Note that /proc/scsi/* has been deprecated since mid-2.5.x.