Re: [PATCH] Use proper seq_file api for /proc/scsi/scsi

[Jeremy Higdon <jeremy@sgi.com>]

On Fri, Apr 08, 2005 at 08:56:43AM +0100, Christoph Hellwig wrote:
> On Fri, Apr 08, 2005 at 12:23:46AM -0700, Jeremy Higdon wrote:
> > Even if it's deprecated, wouldn't it be good to fix it as long as
> > it's there, unless it hurts something else?  Or at least fix the
> > out of memory error, even if it doesn't display all the luns?
> 
> What other error would you return?  I don't particularly care what exact

Hmm.  Well maybe you're right -- an error is probably better than no
error if not printing all devices.

> error code to return, but putting in Hannes patch would be a bad idea because
> it
> 
>   a) poke deep into driver model internals, and we absolutely want to avoid
>      that
>   b) sets a bad precedence that we'll continue adding features to deprecated
>      interface and thus encurage people to contiue using it.  Note that
>      /proc/scsi/* has been deprecated since mid-2.5.x.

Just as a sanity check, you meant "lsscsi" and not "lssci" in your original
reply, right?

jeremy