From: Adrian Bunk <bunk@stusta.de>
To: andrew.vasquez@qlogic.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [2.6 patch] drivers/scsi/qla2xxx/qla_os.c: remove dead code
Date: Sun, 10 Apr 2005 01:06:17 +0200 [thread overview]
Message-ID: <20050409230617.GQ3632@stusta.de> (raw)
This patch removes some dead code found by the Coverity checker (rval
can't be FAILED at the time of this check).
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.12-rc2-mm2-full/drivers/scsi/qla2xxx/qla_os.c.old 2005-04-09 22:24:09.000000000 +0200
+++ linux-2.6.12-rc2-mm2-full/drivers/scsi/qla2xxx/qla_os.c 2005-04-09 22:49:01.000000000 +0200
@@ -1649,14 +1649,11 @@ qla2xxx_eh_host_reset(struct scsi_cmnd *
clear_bit(ABORT_ISP_ACTIVE, &ha->dpc_flags);
spin_lock_irq(ha->host->host_lock);
- if (rval == FAILED)
- goto out;
/* Waiting for our command in done_queue to be returned to OS.*/
if (!qla2x00_eh_wait_for_pending_commands(ha))
rval = FAILED;
- out:
qla_printk(KERN_INFO, ha, "%s: reset %s\n", __func__,
(rval == FAILED) ? "failed" : "succeded");
reply other threads:[~2005-04-09 23:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050409230617.GQ3632@stusta.de \
--to=bunk@stusta.de \
--cc=andrew.vasquez@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox