From: Christoph Hellwig <hch@infradead.org>
To: Tobias Klauser <tklauser@nuerscht.ch>
Cc: kernel-janitors@lists.osdl.org, linux-scsi@vger.kernel.org
Subject: [KJ] Re: [PATCH] scsi/a100u2w: Remove custom msecs_to_jiffies and jiffies_to_msecs macros
Date: Wed, 13 Apr 2005 15:51:00 +0100 [thread overview]
Message-ID: <20050413145100.GA9958@infradead.org> (raw)
In-Reply-To: <20050413144308.GA9616@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 477 bytes --]
On Wed, Apr 13, 2005 at 03:43:08PM +0100, Christoph Hellwig wrote:
> > static void waitForPause(unsigned amount)
> > {
> > - ULONG the_time = jiffies + MS_TO_JIFFIES(amount);
> > + ULONG the_time = jiffies + msecs_to_jiffies(amount);
> > while (time_before_eq(jiffies, the_time))
> > cpu_relax();
>
> You should probably replace this function with msleep completely.
I actually meant mdelay, but as mentioned in the other followup that might
need some more research.
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2005-04-13 14:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-13 12:11 [PATCH] scsi/a100u2w: Remove custom msecs_to_jiffies and jiffies_to_msecs macros Tobias Klauser
2005-04-13 14:43 ` Christoph Hellwig
2005-04-13 14:51 ` Christoph Hellwig [this message]
2005-04-13 15:00 ` [KJ] " James Bottomley
2005-04-13 15:01 ` Tobias Klauser
2005-04-13 17:28 ` [KJ] " Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050413145100.GA9958@infradead.org \
--to=hch@infradead.org \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tklauser@nuerscht.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox