From: Christoph Hellwig <hch@infradead.org>
To: Tejun Heo <htejun@gmail.com>
Cc: Eric.Moore@lsil.com,
James Bottomley <James.Bottomley@SteelEye.com>,
linux-scsi@vger.kernel.org
Subject: Re: Question about scsi_device_online() usage in mptscsih
Date: Thu, 14 Apr 2005 19:54:12 +0100 [thread overview]
Message-ID: <20050414185412.GA6929@infradead.org> (raw)
In-Reply-To: <20050402053557.GA22422@htj.dyndns.org>
On Sat, Apr 02, 2005 at 02:35:57PM +0900, Tejun Heo wrote:
> Hello, Eric.
> Hello, James.
>
> I've been working on new SCSI state model and was checking on
> scsi_device_online() users. As the state model is going to change, I
> need to audit device state usages in lldd's and I'm having difficult
> time understanding why scsi_device_online() is used in mptscsih.
>
> In mptscsih.c, mptscsih_flush_running_cmds() uses
> scsi_device_online() to determine whether or not dma-unmap data area
> of active commands. This was added in the changeset 1.1371.776.1 by
> Eric Moore with the comment "MPT Fusion add back FC909 support". Can
> you please explain me why and how scsi_device_online() condition is
> used here?
I brought that issue up a while ago, but we didn't really get anywhere,
see the "fix dma mapping leak in fusion" thread on linux-scsi.
next prev parent reply other threads:[~2005-04-14 18:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-02 5:35 Question about scsi_device_online() usage in mptscsih Tejun Heo
2005-04-14 18:54 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-04-14 20:28 Moore, Eric Dean
2005-04-15 10:13 ` Masao Fukuchi
2005-04-15 14:30 ` James Bottomley
2005-04-15 16:11 Moore, Eric Dean
2005-04-15 16:41 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050414185412.GA6929@infradead.org \
--to=hch@infradead.org \
--cc=Eric.Moore@lsil.com \
--cc=James.Bottomley@SteelEye.com \
--cc=htejun@gmail.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox