From: Andrew Vasquez <andrew.vasquez@qlogic.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] remove some dead code in qla2xxx
Date: Tue, 19 Apr 2005 00:32:40 -0700 [thread overview]
Message-ID: <20050419073240.GE5999@plap.qlogic.org> (raw)
In-Reply-To: <20050418130334.GA30034@lst.de>
On Mon, 18 Apr 2005, Christoph Hellwig wrote:
>
> ===== drivers/scsi/qla2xxx/qla_dbg.c 1.12 vs edited =====
> --- 1.12/drivers/scsi/qla2xxx/qla_dbg.c 2005-04-13 17:45:53 +02:00
> +++ edited/drivers/scsi/qla2xxx/qla_dbg.c 2005-04-18 16:22:48 +02:00
> @@ -1063,8 +1063,7 @@
> return;
>
> printk(" sp flags=0x%x\n", sp->flags);
> - printk(" r_start=0x%lx, u_start=0x%lx, f_start=0x%lx, state=%d\n",
> - sp->r_start, sp->u_start, sp->f_start, sp->state);
> + printk(" state=%d\n", sp->state);
> }
>
...
Good stuff, I had a (more conservative) patchset in the queue which
began to prune most of the stuff you've wacked with your patch.
Seems reasonable, I'll run it through my test ring tomorrow and ACK
when all looks good.
Thanks,
Andrew Vasquez
next prev parent reply other threads:[~2005-04-19 7:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-18 13:03 [PATCH] remove some dead code in qla2xxx Christoph Hellwig
2005-04-19 7:32 ` Andrew Vasquez [this message]
2005-04-22 6:56 ` Andrew Vasquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050419073240.GE5999@plap.qlogic.org \
--to=andrew.vasquez@qlogic.com \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox