From: Christoph Hellwig <hch@infradead.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-scsi@vger.kernel.org
Subject: Re: streamlining the sym2 io submission path
Date: Wed, 20 Apr 2005 00:48:22 +0100 [thread overview]
Message-ID: <20050419234822.GA22940@infradead.org> (raw)
In-Reply-To: <20050419234323.GA31352@parcelfarce.linux.theplanet.co.uk>
On Wed, Apr 20, 2005 at 12:43:23AM +0100, Matthew Wilcox wrote:
> We fail the first command to the device if the device is marked as
> NOSCAN or the lun is non-0 and the device isn't marked as SCAN LUNS.
> I think the first part should be moved to slave_alloc(); it's a little
> weird, but supportable. The second part troubles me a little -- is the
> blacklist in the midlayer good enough to handle this, or should I leave
> this mechanism in?
For the first make sure to return -ENXIO from ->slave_alloc, the scsi_scan
code special-cases that one and doesn't print an error. For the second
I don't care too much. The midlayer blacklist and if nessecary the
runtime updates to it will handle such devices just fine, but following
them nvram might not be a bad idea either.
> The driver currently fails commands sent to the lun of the host adapter.
> Is this the correct behaviour? What should the driver do?
The driver will never receice a command for the host adapter (unless it
allocates a scsi_device for the host adapter itself, as e.g. gdth does)
prev parent reply other threads:[~2005-04-19 23:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-19 23:43 streamlining the sym2 io submission path Matthew Wilcox
2005-04-19 23:48 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050419234822.GA22940@infradead.org \
--to=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox