public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: linux-scsi@vger.kernel.org
Subject: The future of host_scribble
Date: Thu, 21 Apr 2005 01:23:33 +0100	[thread overview]
Message-ID: <20050421002333.GA8556@parcelfarce.linux.theplanet.co.uk> (raw)


In scsi_cmnd there's an element called host_scribble.  The name and the
comment by it were sufficiently confusing that I didn't realise that this
field is basically for the host's private data.  Any objections to something
like this, assuming I also submit a patch that converts all the drivers?

+++ include/scsi/scsi_cmnd.h    2005-04-20 20:16:41.562034944 -0400
@@ -129,13 +129,8 @@
         */
        struct scsi_pointer SCp;        /* Scratchpad used by some host adapters */
 
-       unsigned char *host_scribble;   /* The host adapter is allowed to
-                                          * call scsi_malloc and get some memory
-                                          * and hang it here.     The host adapter
-                                          * is also expected to call scsi_free
-                                          * to release this memory.  (The memory
-                                          * obtained by scsi_malloc is guaranteed
-                                          * to be at an address < 16Mb). */
+       void *host_data;        /* Pointer to the host's data structure
+                                * associated with this command. */
 
        int result;             /* Status code from lower level driver */
 
(the only remaining references to scsi_malloc are in comments ... I'll
submit a different patch to remove those too)

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain

             reply	other threads:[~2005-04-21  0:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-21  0:23 Matthew Wilcox [this message]
2005-04-21  7:46 ` The future of host_scribble Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050421002333.GA8556@parcelfarce.linux.theplanet.co.uk \
    --to=matthew@wil.cx \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox