From: Christoph Hellwig <hch@infradead.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-scsi@vger.kernel.org
Subject: Re: The future of host_scribble
Date: Thu, 21 Apr 2005 08:46:42 +0100 [thread overview]
Message-ID: <20050421074641.GA17184@infradead.org> (raw)
In-Reply-To: <20050421002333.GA8556@parcelfarce.linux.theplanet.co.uk>
On Thu, Apr 21, 2005 at 01:23:33AM +0100, Matthew Wilcox wrote:
>
> In scsi_cmnd there's an element called host_scribble. The name and the
> comment by it were sufficiently confusing that I didn't realise that this
> field is basically for the host's private data. Any objections to something
> like this, assuming I also submit a patch that converts all the drivers?
Actually the situation about private data in scsi_cmnd is worse, there's
another private data, that's the scsi_pointer structure embedded as SCp
member. If we're going to fix up naming we should find a way to fixup
both an have a sensible name for both embedded and out of struct private
data. I somehow doubt it's going to happen before we drop support for
gcc 2.95 and thus can use anonymous unions :)
prev parent reply other threads:[~2005-04-21 7:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-21 0:23 The future of host_scribble Matthew Wilcox
2005-04-21 7:46 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050421074641.GA17184@infradead.org \
--to=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox