From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] kill old EH constants Date: Thu, 21 Apr 2005 11:09:33 +0100 Message-ID: <20050421100933.GA19586@infradead.org> References: <200504210608.j3L682Br002585@hera.kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:49580 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S261250AbVDUKJf (ORCPT ); Thu, 21 Apr 2005 06:09:35 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Geert Uytterhoeven Cc: "James E.J. Bottomley" , Linux Kernel Development , linux-scsi@vger.kernel.org, Linux/m68k On Thu, Apr 21, 2005 at 11:58:12AM +0200, Geert Uytterhoeven wrote: > sun3_NCR5380.c still uses the following: > > - SCSI_ABORT_SUCCESS > - SCSI_ABORT_ERROR > - SCSI_ABORT_SNOOZE > - SCSI_ABORT_BUSY > - SCSI_ABORT_NOT_RUNNING > - SCSI_RESET_SUCCESS > - SCSI_RESET_BUS_RESET > > causing the driver to fail to build in 2.6.12-rc3. What should I replace them > by? You must replace NCR5380_abort and NCR5380_bus_reset with real new-style EH routines. I'd suggest copying them from NCR5380.c or even better scrapping sun3_NCR5380.c in favour of that one completely.