* [2.6 patch] drivers/scsi/FlashPoint.c: cleanups
@ 2005-04-23 22:17 Adrian Bunk
2005-04-24 7:26 ` Christoph Hellwig
2005-04-25 9:34 ` Alexey Dobriyan
0 siblings, 2 replies; 3+ messages in thread
From: Adrian Bunk @ 2005-04-23 22:17 UTC (permalink / raw)
To: James Bottomley; +Cc: linux-scsi, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 387 bytes --]
This patch contains cleanups including the following:
- remove #ifdef'ed code for other OS's
- remove other unused code
- make needlessly global code static
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
Due to it's size, the patch is attached gzip'ed.
drivers/scsi/FlashPoint.c | 5872 ++++++--------------------------------
1 files changed, 973 insertions(+), 4899 deletions(-)
[-- Attachment #2: patch-cleanup-FlashPoint.gz --]
[-- Type: application/octet-stream, Size: 47304 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 patch] drivers/scsi/FlashPoint.c: cleanups
2005-04-23 22:17 [2.6 patch] drivers/scsi/FlashPoint.c: cleanups Adrian Bunk
@ 2005-04-24 7:26 ` Christoph Hellwig
2005-04-25 9:34 ` Alexey Dobriyan
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2005-04-24 7:26 UTC (permalink / raw)
To: Adrian Bunk; +Cc: James Bottomley, linux-scsi, linux-kernel
On Sun, Apr 24, 2005 at 12:17:12AM +0200, Adrian Bunk wrote:
> This patch contains cleanups including the following:
> - remove #ifdef'ed code for other OS's
> - remove other unused code
> - make needlessly global code static
I'd rather not touch this file currently. It's glued toghether from
lots of separate files in the original code. Before doing cleanups
I'd rather split it into all these files first as the file is a huge
mess as-is.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 patch] drivers/scsi/FlashPoint.c: cleanups
2005-04-23 22:17 [2.6 patch] drivers/scsi/FlashPoint.c: cleanups Adrian Bunk
2005-04-24 7:26 ` Christoph Hellwig
@ 2005-04-25 9:34 ` Alexey Dobriyan
1 sibling, 0 replies; 3+ messages in thread
From: Alexey Dobriyan @ 2005-04-25 9:34 UTC (permalink / raw)
To: Adrian Bunk; +Cc: James Bottomley, linux-scsi, linux-kernel
> This patch contains cleanups including the following:
> - remove #ifdef'ed code for other OS's
> - remove other unused code
> - make needlessly global code static
FYI, (1) and part of your (2) are already sitting in -kj (splitted).
http://coderock.org/kj/2.6.12-rc3-kj/split/defines-drivers_scsi_FlashPoint.patch
http://coderock.org/kj/2.6.12-rc3-kj/split/comments-drivers_scsi_FlashPoint
And I hope cleaning FlashPoint mess will be splitted.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-04-25 9:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-04-23 22:17 [2.6 patch] drivers/scsi/FlashPoint.c: cleanups Adrian Bunk
2005-04-24 7:26 ` Christoph Hellwig
2005-04-25 9:34 ` Alexey Dobriyan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox