From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [06/07] [PATCH] SCSI tape security: require CAP_ADMIN for SG_IO etc. Date: Wed, 27 Apr 2005 11:26:11 -0700 Message-ID: <20050427182610.GA4400@suse.de> References: <20050427171446.GA3195@kroah.com> <20050427171649.GG3195@kroah.com> <1114619928.18809.118.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from lyle.provo.novell.com ([137.65.81.174]:42414 "EHLO lyle.provo.novell.com") by vger.kernel.org with ESMTP id S261935AbVD0S0l (ORCPT ); Wed, 27 Apr 2005 14:26:41 -0400 Content-Disposition: inline In-Reply-To: <1114619928.18809.118.camel@localhost.localdomain> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Alan Cox Cc: James Bottomley , Kai.Makisara@kolumbus.fi, linux-scsi@vger.kernel.org, Linux Kernel Mailing List , stable@kernel.org, Justin Forbes , Zwane Mwaikambo , Cliff White , Theodore Ts'o , "Randy.Dunlap" , Chuck Wolber , torvalds@osdl.org, akpm@osdl.org On Wed, Apr 27, 2005 at 05:38:49PM +0100, Alan Cox wrote: > On Mer, 2005-04-27 at 18:16, Greg KH wrote: > > -stable review patch. If anyone has any objections, please let us know. > > This patch is just wrong on so many different levels its hard to know > where to begin. But that is what is now in mainline, right? If so, all of these questions still pertain to the current tree... > 1. The auth for arbitary commands is CAP_SYS_RAWIO > 2. "The SCSI command permissions were discussed widely on the linux > lists but this did not result in any useful refinement of the > permissions." - this is false. The process was refined, a table setup > was added and debugged. Someone even wrote an fs for managing it that is > not yet merged. Perhaps the patch author would care to re-read the > archives and submit a new patch if one is even needed > 3. Pleas explain *what* the specific consistency problems are > > And then please fix the same mess in 12rc. thanks, greg k-h