From: Bob Picco <bob.picco@hp.com>
To: matthew@wil.cx
Cc: linux-scsi@vger.kernel.org, bob.picco@hp.com
Subject: [PATCH] drivers/scsi/sym53c8xx_2/sym_glue.c
Date: Wed, 27 Apr 2005 15:39:24 -0400 [thread overview]
Message-ID: <20050427193924.GT6147@localhost.localdomain> (raw)
I believe the attempt not to use 64-bit BARs caused an unintended
result. The current code disables MMIO for all 64 bit BARs and not just
those with an address >= 4Gb.
thanks,
bob
Signed-off-by: Bob Picco <bob.picco@hp.com>
Index: linux-memory-less-nodes/drivers/scsi/sym53c8xx_2/sym_glue.c
===================================================================
--- linux-memory-less-nodes.orig/drivers/scsi/sym53c8xx_2/sym_glue.c 2005-04-27 14:17:07.000000000 -0400
+++ linux-memory-less-nodes/drivers/scsi/sym53c8xx_2/sym_glue.c 2005-04-27 14:18:21.000000000 -0400
@@ -155,10 +155,11 @@ pci_get_base_address(struct pci_dev *pde
base = tmp;
if ((tmp & 0x7) == PCI_BASE_ADDRESS_MEM_TYPE_64) {
pci_read_config_dword(pdev, PCI_BAR_OFFSET(index++), &tmp);
- if (tmp > 0)
+ if (tmp > 0) {
dev_err(&pdev->dev,
"BAR %d is 64-bit, disabling\n", index - 1);
- base = 0;
+ base = 0;
+ }
}
if ((base & PCI_BASE_ADDRESS_SPACE) == PCI_BASE_ADDRESS_SPACE_IO) {
next reply other threads:[~2005-04-27 19:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-27 19:39 Bob Picco [this message]
2005-05-02 20:02 ` [PATCH] drivers/scsi/sym53c8xx_2/sym_glue.c Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050427193924.GT6147@localhost.localdomain \
--to=bob.picco@hp.com \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox