[PATCH] drivers/scsi/sym53c8xx_2/sym_glue.c

[PATCH] drivers/scsi/sym53c8xx_2/sym_glue.c

[Bob Picco]

I believe the attempt not to use 64-bit BARs caused an unintended
result.  The current code disables MMIO for all 64 bit BARs and not just 
those with an address >= 4Gb.

thanks,


bob

Signed-off-by: Bob Picco <bob.picco@hp.com>


Index: linux-memory-less-nodes/drivers/scsi/sym53c8xx_2/sym_glue.c
===================================================================
--- linux-memory-less-nodes.orig/drivers/scsi/sym53c8xx_2/sym_glue.c	2005-04-27 14:17:07.000000000 -0400
+++ linux-memory-less-nodes/drivers/scsi/sym53c8xx_2/sym_glue.c	2005-04-27 14:18:21.000000000 -0400
@@ -155,10 +155,11 @@ pci_get_base_address(struct pci_dev *pde
 	base = tmp;
 	if ((tmp & 0x7) == PCI_BASE_ADDRESS_MEM_TYPE_64) {
 		pci_read_config_dword(pdev, PCI_BAR_OFFSET(index++), &tmp);
-		if (tmp > 0)
+		if (tmp > 0) {
 			dev_err(&pdev->dev,
 				"BAR %d is 64-bit, disabling\n", index - 1);
-		base = 0;
+			base = 0;
+		}
 	}
 
 	if ((base & PCI_BASE_ADDRESS_SPACE) == PCI_BASE_ADDRESS_SPACE_IO) {

Re: [PATCH] drivers/scsi/sym53c8xx_2/sym_glue.c

[Matthew Wilcox]

On Wed, Apr 27, 2005 at 03:39:24PM -0400, Bob Picco wrote:
> I believe the attempt not to use 64-bit BARs caused an unintended
> result.  The current code disables MMIO for all 64 bit BARs and not just 
> those with an address >= 4Gb.

Thanks, Bob.  You're quite right.  The code made a lot more sense when I
was trying to handle a real 64-bit BAR, but after I decided that changing
the rest of the driver to support this rare case was more trouble than
warranted, I didn't quite get it right.  I'll try and get 2.2.1 out today.

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain