Re: [06/07] [PATCH] SCSI tape security: require CAP_ADMIN for SG_IO etc.

Greg KH
2005-04-27T18:26:41Z

On Wed, Apr 27, 2005 at 05:38:49PM +0100, Alan Cox wrote:
> On Mer, 2005-04-27 at 18:16, Greg KH wrote:
> > -stable review patch. If anyone has any objections, please let us know.
>
> This patch is just wrong on so many different levels its hard to know
> where to begin.

But that is what is now in mainline, right? If so, all of these
questions still pertain to the current tree...

> 1. The auth for arbitary commands is CAP_SYS_RAWIO
> 2. "The SCSI command permissions were discussed widely on the linux
> lists but this did not result in any useful refinement of the
> permissions." - this is false. The process was refined, a table setup
> was added and debugged. Someone even wrote an fs for managing it that is
> not yet merged. Perhaps the patch author would care to re-read the
> archives and submit a new patch if one is even needed
> 3. Pleas explain *what* the specific consistency problems are
>
> And then please fix the same mess in 12rc.

thanks,

greg k-h