From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [06/07] [PATCH] SCSI tape security: require CAP_ADMIN for SG_IO etc. Date: Fri, 29 Apr 2005 22:10:31 -0700 Message-ID: <20050430051030.GA10005@suse.de> References: <20050427171446.GA3195@kroah.com> <20050427171649.GG3195@kroah.com> <1114619928.18809.118.camel@localhost.localdomain> <1114694511.18809.187.camel@localhost.localdomain> <20050429042014.GC25474@kroah.com> <1114805784.18330.297.camel@localhost.localdomain> <20050429203805.GA2959@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from lyle.provo.novell.com ([137.65.81.174]:34925 "EHLO lyle.provo.novell.com") by vger.kernel.org with ESMTP id S262524AbVD3GK6 (ORCPT ); Sat, 30 Apr 2005 02:10:58 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Kai Makisara Cc: Greg KH , Alan Cox , James Bottomley , linux-scsi@vger.kernel.org, Linux Kernel Mailing List , stable@kernel.org, Justin Forbes , Zwane Mwaikambo , Cliff White , Theodore Ts'o , "Randy.Dunlap" , Chuck Wolber , torvalds@osdl.org, Andrew Morton On Sat, Apr 30, 2005 at 08:52:31AM +0300, Kai Makisara wrote: > On Fri, 29 Apr 2005, Greg KH wrote: > > > On Fri, Apr 29, 2005 at 09:16:27PM +0100, Alan Cox wrote: > > > On Gwe, 2005-04-29 at 05:20, Greg KH wrote: > > > > > Ok thats the bit I needed to know > > > > > > > > So, do you still object to this patch being accepted? > > > > > > Switched to CAP_SYS_RAWIO I don't. Its the wrong answer long term I > > > suspect but its definitely a good answer for now. > > > > Switch it in both capable() calls in the patch? Kai, is this acceptable > > to you also? > > > Yes. Using CAP_SYS_ADMIN here was wrong. Ok, care to send a new patch that I can use for the next -stable kernel release? thanks, greg k-h