public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: Bob Picco <bob.picco@hp.com>
Cc: matthew@wil.cx, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] drivers/scsi/sym53c8xx_2/sym_glue.c
Date: Mon, 2 May 2005 21:02:10 +0100	[thread overview]
Message-ID: <20050502200210.GA19678@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20050427193924.GT6147@localhost.localdomain>

On Wed, Apr 27, 2005 at 03:39:24PM -0400, Bob Picco wrote:
> I believe the attempt not to use 64-bit BARs caused an unintended
> result.  The current code disables MMIO for all 64 bit BARs and not just 
> those with an address >= 4Gb.

Thanks, Bob.  You're quite right.  The code made a lot more sense when I
was trying to handle a real 64-bit BAR, but after I decided that changing
the rest of the driver to support this rare case was more trouble than
warranted, I didn't quite get it right.  I'll try and get 2.2.1 out today.

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain

      reply	other threads:[~2005-05-02 20:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-27 19:39 [PATCH] drivers/scsi/sym53c8xx_2/sym_glue.c Bob Picco
2005-05-02 20:02 ` Matthew Wilcox [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050502200210.GA19678@parcelfarce.linux.theplanet.co.uk \
    --to=matthew@wil.cx \
    --cc=bob.picco@hp.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox