From: Patrick Mansfield <patmans@us.ibm.com>
To: Luben Tuikov <luben_tuikov@adaptec.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
James Bottomley <James.Bottomley@SteelEye.com>,
Doug Gilbert <dgilbert@interlog.com>,
SCSI development list <linux-scsi@vger.kernel.org>
Subject: Re: sg driver and the error handler
Date: Wed, 11 May 2005 10:14:25 -0700 [thread overview]
Message-ID: <20050511171425.GA9286@us.ibm.com> (raw)
In-Reply-To: <42823565.9000806@adaptec.com>
On Wed, May 11, 2005 at 12:40:05PM -0400, Luben Tuikov wrote:
> On 05/10/05 18:58, Patrick Mansfield wrote:
> > As you say, what you really want is the correct result going back to the
> > user, not the result of the TUR.
> >
> > So save and restore the result in scsi_eh_tur, and also in scsi_eh_try_stu.
> > The request sense one already saves and restores it.
>
> I think he even wants the stronger condition -- after the command is reclaimed
> from the LLDD, just send back the result to the application client. And let
> the application client decide whether they want to send TUR or something else.
The TUR is part of the error recovery, and so it should be sent
independent of the timed out command.
I know we want to have transport specific error (or timeout) handling and
recovery. But for current usage, we should return the result of the
timeout to the upper level driver (and implicitly to the application).
-- Patrick Mansfield
next prev parent reply other threads:[~2005-05-11 17:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-10 18:51 sg driver and the error handler Alan Stern
2005-05-10 22:58 ` Patrick Mansfield
2005-05-11 11:59 ` Douglas Gilbert
2005-05-11 16:35 ` Luben Tuikov
2005-05-11 17:45 ` Patrick Mansfield
2005-05-11 17:55 ` Luben Tuikov
2005-05-11 18:02 ` Patrick Mansfield
2005-05-11 19:43 ` Alan Stern
2005-05-11 16:40 ` Luben Tuikov
2005-05-11 17:14 ` Patrick Mansfield [this message]
2005-05-16 17:42 ` [PATCH] saved and restore result for timed out commands Patrick Mansfield
2005-05-16 19:42 ` Alan Stern
2005-06-01 18:45 ` Alan Stern
2005-06-01 21:00 ` James Bottomley
2005-06-01 21:26 ` Alan Stern
2005-06-01 21:57 ` Patrick Mansfield
2005-06-03 15:21 ` James Bottomley
2005-06-03 15:35 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050511171425.GA9286@us.ibm.com \
--to=patmans@us.ibm.com \
--cc=James.Bottomley@SteelEye.com \
--cc=dgilbert@interlog.com \
--cc=linux-scsi@vger.kernel.org \
--cc=luben_tuikov@adaptec.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox