From: Christoph Hellwig <hch@infradead.org>
To: Hannes Reinecke <hare@suse.de>
Cc: James Bottomley <James.Bottomley@SteelEye.com>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] Sanitize PQ3 device handling
Date: Wed, 18 May 2005 15:14:59 +0100 [thread overview]
Message-ID: <20050518141459.GA22916@infradead.org> (raw)
In-Reply-To: <428B4BB0.9040306@suse.de>
On Wed, May 18, 2005 at 04:05:36PM +0200, Hannes Reinecke wrote:
> > If scsi_probe_and_add_lun returns SCSI_SCAN_TARGET_PRESENT sdev isn't valid at
> > this point. You should probably default to SCSI_2 for that case.
> >
> How so? This is exactly the behaviour I've removed. sdev is valid even
> for SCSI_SCAN_TARGET_PRESENT.
> If not please show me.
Indeed, you replaced the check at the end of scsi_probe_and_add_lun. I don't
think it makes a lot of sense to leave around the stale scsi_dev for PQ3, though.
Doing a REPORT_LUNS for SCSI_SCAN_TARGET_PRESENT does OTOH make a lot of sense,
there's nothing in the spec against it. So what about dropping that device
after we're done with REPORT_LUNS?
next prev parent reply other threads:[~2005-05-18 14:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-18 9:43 [PATCH] Sanitize PQ3 device handling Hannes Reinecke
2005-05-18 14:01 ` Christoph Hellwig
2005-05-18 14:05 ` Hannes Reinecke
2005-05-18 14:14 ` Christoph Hellwig [this message]
2005-05-18 14:33 ` Hannes Reinecke
2005-05-18 17:06 ` Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050518141459.GA22916@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@SteelEye.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox