Re: [PATCH] 2.6 aacraid: Add sysfs files for aacraid adapter information (re-diff)

[Christoph Hellwig <hch@infradead.org>]

On Mon, May 23, 2005 at 11:36:48AM -0700, Mark Haverkamp wrote:
> > the "Adaptec Raid Controller:" doesn't belong in here.  The driver build
> > data and version neither, use MODULE_VERSION instead.
> 
> Using MODULE_VERSION in the snprinf doesn't seem to work:
> 
> drivers/scsi/aacraid/linit.c: In function `aac_show_host_version':
> drivers/scsi/aacraid/linit.c:541: error: `MODULE_VERSION' undeclared (first use in this function)

sorry, MODULE_VERSION is a macro similar to MODULE_LICENSE or MODULE_AUTHOR.
You say MODULE_VERSION("something"); outside any function and you can find
the version out using modinfo and sysfs (not sure the latter is implemented
yet, but there were patches floating around)

> > > +
> > > +static ssize_t aac_show_model(struct class_device *class_dev,
> > > +		char *buf)
> > > +{
> > > +	struct aac_dev *dev = (struct aac_dev*)class_to_shost(class_dev)->hostdata;
> > 
> > No need to cast.
> 
> It looks like the cast is needed.  If I remove it I get a compile
> warning.
> 
> drivers/scsi/aacraid/linit.c: In function `aac_show_model':
> drivers/scsi/aacraid/linit.c:548: warning: initialization from incompatible pointer type

Sorry, you're right.  hostdata is an unsigned long.