From: Matt Domsch <Matt_Domsch@dell.com>
To: Mark Haverkamp <markh@osdl.org>
Cc: Christoph Hellwig <hch@infradead.org>,
James Bottomley <James.Bottomley@steeleye.com>,
linux-scsi <linux-scsi@vger.kernel.org>,
Mark Salyzyn <mark_salyzyn@adaptec.com>
Subject: Re: [PATCH] 2.6 aacraid: Add sysfs files for aacraid adapter information (re-diff)
Date: Mon, 23 May 2005 22:30:21 -0500 [thread overview]
Message-ID: <20050524033020.GA23998@lists.us.dell.com> (raw)
In-Reply-To: <1116881371.22284.29.camel@markh1.pdx.osdl.net>
On Mon, May 23, 2005 at 01:49:30PM -0700, Mark Haverkamp wrote:
> On Mon, 2005-05-23 at 19:46 +0100, Christoph Hellwig wrote:
> > On Mon, May 23, 2005 at 11:36:48AM -0700, Mark Haverkamp wrote:
> > > > the "Adaptec Raid Controller:" doesn't belong in here. The driver build
> > > > data and version neither, use MODULE_VERSION instead.
> > >
> > > Using MODULE_VERSION in the snprinf doesn't seem to work:
> > >
> > > drivers/scsi/aacraid/linit.c: In function `aac_show_host_version':
> > > drivers/scsi/aacraid/linit.c:541: error: `MODULE_VERSION' undeclared (first use in this function)
> >
> > sorry, MODULE_VERSION is a macro similar to MODULE_LICENSE or MODULE_AUTHOR.
> > You say MODULE_VERSION("something"); outside any function and you can find
> > the version out using modinfo and sysfs (not sure the latter is implemented
> > yet, but there were patches floating around)
>
> I haven't seen anything to display MODULE_VERSION in sysfs.
http://marc.theaimsgroup.com/?l=linux-kernel&m=110671970405497&w=2
was posted, not included yet, and I haven't pushed it again lately
waiting for 2.6.12 to settle.
> How about If I just print out AAC_DRIVER_VERSION which is what is
> passed into the MODULE_VERSION macro.
That's what others do (ethtool -i), so seems sane if you really need
it exported in sysfs before the above is merged. What's the rush
though? If it can wait a release, I'll push on the above then it'll
be there for all modules.
Thanks,
Matt
--
Matt Domsch
Software Architect
Dell Linux Solutions linux.dell.com & www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com
next prev parent reply other threads:[~2005-05-24 3:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-17 20:34 [PATCH] 2.6 aacraid: Add sysfs files for aacraid adapter information (re-diff) Mark Haverkamp
2005-05-22 16:54 ` Christoph Hellwig
2005-05-23 18:36 ` Mark Haverkamp
2005-05-23 18:46 ` Christoph Hellwig
2005-05-23 20:49 ` Mark Haverkamp
2005-05-24 3:30 ` Matt Domsch [this message]
2005-05-24 14:18 ` Mark Haverkamp
-- strict thread matches above, loose matches on Subject: below --
2005-05-23 11:56 Salyzyn, Mark
2005-05-23 12:20 ` Arjan van de Ven
2005-05-23 13:46 ` Christoph Hellwig
2005-05-23 19:12 Salyzyn, Mark
2005-05-24 11:35 Salyzyn, Mark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050524033020.GA23998@lists.us.dell.com \
--to=matt_domsch@dell.com \
--cc=James.Bottomley@steeleye.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mark_salyzyn@adaptec.com \
--cc=markh@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox