Re: [PATCH] libata: device suspend/resume

Mark Lord
2005-05-24T16:27:25Z

>> Patch is via Mark Lord,
>
>Um, it is? it looks identical to this one from Jens
...

As Jeff said, he got the patch "via" me.
Here are the first few lines from the file I sent to Jeff (below),
just to make it clear I never tried to claim it as my own.

Cheers
--
Mark Lord

From: Hannes Reinecke <hare@suse.de>
Subject: Fix sata atapi error handling
References: 70918

SCSI commands which end up on the error handler need special attention;
we have to make sure that eh_cmd_q is properly emptied or scsi_eh will
try to forever finalize the command.

With this patch eh_cmd_q is explicitely emptied if not done so in the
strategy handler and a proper abort sequence is executed for each
command if required.
We rely on the strategy handler to fill out proper sense information for
us as SATA is 'special' when it comes to command sense gathering.

Signed-off-by: Kurt Garloff <garloff@suse.de>
Signed-off-by: Jens Axboe <axboe@suse.de>
Acked-by: Andreas Gruenbacher <agruen@suse.de>
...