From: Andrew Vasquez <andrew.vasquez@qlogic.com>
To: Linux-SCSI Mailing List <linux-scsi@vger.kernel.org>
Cc: James Bottomley <James.Bottomley@SteelEye.com>
Subject: [PATCH] qla2xxx: fix bad locking during eh_abort
Date: Thu, 26 May 2005 16:19:38 -0700 [thread overview]
Message-ID: <20050526231938.GA31205@plap.qlogic.org> (raw)
James,
Please apply, this should go in before 2.6.12 is released.
Correct incorrect locking order in qla2xxx_eh_abort() handler which
would case a hang during certain code-paths.
Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
---
drivers/scsi/qla2xxx/qla_os.c | 3 +--
1 files changed, 1 insertion(+), 2 deletions(-)
drivers/scsi/qla2xxx/qla_os.c: needs update
Index: drivers/scsi/qla2xxx/qla_os.c
===================================================================
--- d9be308337b4cca0f0829b0bd62f1d5b830954e1/drivers/scsi/qla2xxx/qla_os.c (mode:100644)
+++ uncommitted/drivers/scsi/qla2xxx/qla_os.c (mode:100644)
@@ -547,16 +547,15 @@
break;
}
+ spin_unlock(&ha->hardware_lock);
/* Wait for the command to be returned. */
if (ret == SUCCESS) {
- spin_unlock(&ha->hardware_lock);
if (qla2x00_eh_wait_on_command(ha, cmd) != QLA_SUCCESS) {
qla_printk(KERN_ERR, ha,
"scsi(%ld:%d:%d): Abort handler timed out -- %lx "
"%x.\n", ha->host_no, id, lun, serial, ret);
}
- spin_lock(&ha->hardware_lock);
}
spin_lock_irq(ha->host->host_lock);
next reply other threads:[~2005-05-26 23:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-26 23:19 Andrew Vasquez [this message]
2005-05-27 20:06 ` [PATCH] qla2xxx: fix bad locking during eh_abort James Bottomley
2005-05-27 20:18 ` Andrew Vasquez
2005-05-27 20:30 ` Jeff Garzik
2005-05-27 20:38 ` James Bottomley
2005-05-27 20:42 ` Jeff Garzik
2005-05-27 22:04 ` Andrew Vasquez
2005-05-27 22:47 ` Jeff Garzik
2005-05-27 20:31 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050526231938.GA31205@plap.qlogic.org \
--to=andrew.vasquez@qlogic.com \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox