From: Patrick Mansfield <patmans@us.ibm.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: James Bottomley <James.Bottomley@SteelEye.com>,
Doug Gilbert <dgilbert@interlog.com>,
SCSI development list <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] saved and restore result for timed out commands
Date: Wed, 1 Jun 2005 14:57:32 -0700 [thread overview]
Message-ID: <20050601215732.GA27734@us.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0506011708410.5912-100000@iolanthe.rowland.org>
On Wed, Jun 01, 2005 at 05:26:34PM -0400, Alan Stern wrote:
> On Wed, 1 Jun 2005, James Bottomley wrote:
>
> > On Wed, 2005-06-01 at 14:45 -0400, Alan Stern wrote:
> > > Has there been any more progress on this issue?
> >
> > Well, the patch is in scsi-misc, if that's what you're asking.
>
> That's good. Is it too much to ask for an additional patch to zero out
> the sense data buffer after the error handler has finished with a command?
> After a transport error or a timeout there shouldn't be any sense data
> (races aside), but the error handler often leaves apparently valid data in
> the buffer, unrelated to the original command.
I was hoping someone else might comment on that, I am not certain if sense
data is valid only when CHECK_CONDITION is set.
But, we can zero/clear it after the TUR without hurting anything.
-- Patrick Mansfield
next prev parent reply other threads:[~2005-06-01 21:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-10 18:51 sg driver and the error handler Alan Stern
2005-05-10 22:58 ` Patrick Mansfield
2005-05-11 11:59 ` Douglas Gilbert
2005-05-11 16:35 ` Luben Tuikov
2005-05-11 17:45 ` Patrick Mansfield
2005-05-11 17:55 ` Luben Tuikov
2005-05-11 18:02 ` Patrick Mansfield
2005-05-11 19:43 ` Alan Stern
2005-05-11 16:40 ` Luben Tuikov
2005-05-11 17:14 ` Patrick Mansfield
2005-05-16 17:42 ` [PATCH] saved and restore result for timed out commands Patrick Mansfield
2005-05-16 19:42 ` Alan Stern
2005-06-01 18:45 ` Alan Stern
2005-06-01 21:00 ` James Bottomley
2005-06-01 21:26 ` Alan Stern
2005-06-01 21:57 ` Patrick Mansfield [this message]
2005-06-03 15:21 ` James Bottomley
2005-06-03 15:35 ` Alan Stern
[not found] <20050603160921.GA32212@us.ibm.com>
2005-06-03 16:37 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050601215732.GA27734@us.ibm.com \
--to=patmans@us.ibm.com \
--cc=James.Bottomley@SteelEye.com \
--cc=dgilbert@interlog.com \
--cc=linux-scsi@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox