public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] aic7xxx: do not check for duplicate pci ids
@ 2005-06-10 22:15 Christoph Hellwig
  2005-06-11 18:34 ` jgarzik
  0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2005-06-10 22:15 UTC (permalink / raw)
  To: jejb; +Cc: linux-scsi

pci layer handles this just fine for us


Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: scsi-misc-2.6/drivers/scsi/aic7xxx/aic7xxx_osm_pci.c
===================================================================
--- scsi-misc-2.6.orig/drivers/scsi/aic7xxx/aic7xxx_osm_pci.c	2005-06-03 16:52:59.000000000 +0200
+++ scsi-misc-2.6/drivers/scsi/aic7xxx/aic7xxx_osm_pci.c	2005-06-03 17:03:42.000000000 +0200
@@ -164,22 +164,6 @@
 	char		*name;
 	int		 error;
 
-	/*
-	 * Some BIOSen report the same device multiple times.
-	 */
-	TAILQ_FOREACH(ahc, &ahc_tailq, links) {
-		struct pci_dev *probed_pdev;
-
-		probed_pdev = ahc->dev_softc;
-		if (probed_pdev->bus->number == pdev->bus->number
-		 && probed_pdev->devfn == pdev->devfn)
-			break;
-	}
-	if (ahc != NULL) {
-		/* Skip duplicate. */
-		return (-ENODEV);
-	}
-
 	pci = pdev;
 	entry = ahc_find_pci_device(pci);
 	if (entry == NULL)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] aic7xxx: do not check for duplicate pci ids
  2005-06-10 22:15 [PATCH] aic7xxx: do not check for duplicate pci ids Christoph Hellwig
@ 2005-06-11 18:34 ` jgarzik
  2005-06-11 18:37   ` Christoph Hellwig
  0 siblings, 1 reply; 3+ messages in thread
From: jgarzik @ 2005-06-11 18:34 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: jejb, linux-scsi

On Sat, Jun 11, 2005 at 12:15:31AM +0200, Christoph Hellwig wrote:
> pci layer handles this just fine for us
> 
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Is there a similar patch for aic79xx?

	Jeff




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] aic7xxx: do not check for duplicate pci ids
  2005-06-11 18:34 ` jgarzik
@ 2005-06-11 18:37   ` Christoph Hellwig
  0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2005-06-11 18:37 UTC (permalink / raw)
  To: jgarzik; +Cc: Christoph Hellwig, jejb, linux-scsi

On Sat, Jun 11, 2005 at 07:34:35PM +0100, jgarzik@pentafluge.infradead.org wrote:
> On Sat, Jun 11, 2005 at 12:15:31AM +0200, Christoph Hellwig wrote:
> > pci layer handles this just fine for us
> > 
> > 
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Is there a similar patch for aic79xx?

and equivalent patch would apply, but probably conflict with other
pending changes.  Let's get transport class support finished for
aic79xx adn then we can port over misc cleanups.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2005-06-11 18:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-06-10 22:15 [PATCH] aic7xxx: do not check for duplicate pci ids Christoph Hellwig
2005-06-11 18:34 ` jgarzik
2005-06-11 18:37   ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox