public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Andrew Vasquez <andrew.vasquez@qlogic.com>
Cc: James Bottomley <James.Bottomley@SteelEye.com>,
	Linux-SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 6/11]  qla2xxx: Add ISP24xx IOCB manipulation routines.
Date: Tue, 14 Jun 2005 22:50:41 +0100	[thread overview]
Message-ID: <20050614215041.GD5849@infradead.org> (raw)
In-Reply-To: <20050614053207.12127.3402.sendpatchset@plap.qlogic.com>

> + * @sp: command to send to the ISP
> + *
> + * Returns non-zero if a failure occured, else zero.
> + */
> +int
> +qla24xx_start_scsi(srb_t *sp)

It'd rather see 24xx having it's own ->queuecommand then adding another
dispatch layer slightly below it.  Put the code before and after _start_scsi
into nice helpers so it's shared.


  reply	other threads:[~2005-06-14 21:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-14  5:31 [PATCH 0/11] qla2xxx: Add ISP24xx support Andrew Vasquez
2005-06-14  5:31 ` [PATCH 1/11] qla2xxx: Add ISP24xx definitions Andrew Vasquez
2005-06-14 21:50   ` Christoph Hellwig
2005-06-21 18:23     ` Andrew Vasquez
2005-06-14  5:31 ` [PATCH 2/11] qla2xxx: Add ISP24xx diagnostic routines Andrew Vasquez
2005-06-14  5:31 ` [PATCH 3/11] qla2xxx: Generalize SNS generic-services routines Andrew Vasquez
2005-06-14 21:50   ` Christoph Hellwig
2005-06-14  5:31 ` [PATCH 4/11] qla2xxx: Add MBX command routines for ISP24xx support Andrew Vasquez
2005-06-14 21:50   ` Christoph Hellwig
2005-06-14  5:32 ` [PATCH 5/11] qla2xxx: Add ISP24xx flash-manipulation routines Andrew Vasquez
2005-06-14  5:32 ` [PATCH 6/11] qla2xxx: Add ISP24xx IOCB manipulation routines Andrew Vasquez
2005-06-14 21:50   ` Christoph Hellwig [this message]
2005-06-14  5:32 ` [PATCH 7/11] qla2xxx: ISP24xx ISR routines Andrew Vasquez
2005-06-14  5:32 ` [PATCH 8/11] qla2xxx: Final glue-code for ISP24xx Andrew Vasquez
2005-06-14 21:50   ` Christoph Hellwig
2005-06-14  5:32 ` [PATCH 9/11] qla2xxx: NVRAM id-list updates Andrew Vasquez
2005-06-14  5:32 ` [PATCH 10/11] qla2xxx: Code scrubbing Andrew Vasquez
2005-06-14  5:32 ` [PATCH 11/11] qla2xxx: Firmware updates Andrew Vasquez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050614215041.GD5849@infradead.org \
    --to=hch@infradead.org \
    --cc=James.Bottomley@SteelEye.com \
    --cc=andrew.vasquez@qlogic.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox