From: Christoph Hellwig <hch@infradead.org>
To: Patrick Mansfield <patmans@us.ibm.com>
Cc: Christoph Hellwig <hch@infradead.org>,
James.Smart@Emulex.Com, linux-scsi@vger.kernel.org
Subject: Re: [Patch] take 4: Correct issue with midlayer scsi target allocation and transports that create the targets
Date: Fri, 17 Jun 2005 12:11:50 +0100 [thread overview]
Message-ID: <20050617111150.GB12178@infradead.org> (raw)
In-Reply-To: <20050614225433.GA16140@us.ibm.com>
On Tue, Jun 14, 2005 at 03:54:33PM -0700, Patrick Mansfield wrote:
> > scsi_get_host_dev is a library function for LLDDs and does not need to
> > care about this.
>
> But if the transport is like FC or iSCSI, the eventual calls to
> scsi_alloc_sdev() will fail (for qlogic, ->slave_alloc returns ENXIO) or
> somehow be incorrect, so why not change these?
I'd rather see people not using it. And in case we need any caller
to use scsi_target_parent we should consolidate this. Anyway we should
have a simple as possible patch for 2.6.12. Probably the one before
this one.
next prev parent reply other threads:[~2005-06-17 11:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-11 2:24 [Patch] Correct issue with midlayer scsi target allocation and transports that create the targets James.Smart
2005-06-11 15:37 ` Christoph Hellwig
2005-06-11 18:15 ` Patrick Mansfield
2005-06-11 18:18 ` Christoph Hellwig
2005-06-14 22:17 ` [Patch] take 4: " Patrick Mansfield
2005-06-14 22:35 ` Christoph Hellwig
2005-06-14 22:54 ` Patrick Mansfield
2005-06-17 11:11 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-06-17 13:08 James.Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050617111150.GB12178@infradead.org \
--to=hch@infradead.org \
--cc=James.Smart@Emulex.Com \
--cc=linux-scsi@vger.kernel.org \
--cc=patmans@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox