From: Christoph Hellwig <hch@lst.de>
To: "David S. Miller" <davem@davemloft.net>
Cc: jejb@steeleye.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] remove drivers/fc4/
Date: Sun, 19 Jun 2005 22:40:08 +0200 [thread overview]
Message-ID: <20050619204008.GA26389@lst.de> (raw)
In-Reply-To: <20050619.125747.35507641.davem@davemloft.net>
On Sun, Jun 19, 2005 at 12:57:47PM -0700, David S. Miller wrote:
> From: Christoph Hellwig <hch@lst.de>
> Subject: [PATCH] remove drivers/fc4/
> Date: Sun, 19 Jun 2005 13:37:24 +0200
>
> > This code doesn't work since 2.2.x times, uses various obsolete APIs,
> > pokes into the midlayer code where it shouldn't and thus won't even
> > have a chance to compile after my next round of patches.
> >
> > Let's get rid of it, anyone who wants to resurrect it can find it
> > in the archives, and it'll require a major rewrite anyway.
>
> It does work for some people. People do use it.
Who? looking at sparclinux doesn't show anyone who got it working
since 2.2.x days.
> It built just fine before changes started going in
> lately. Removing it is not a magic escape hatch you
> get to use because you want to change some interfaces
> but don't know how to do so without breaking the
> driver.
It's doing completely stupid things about poking into EH internals.
This never was an API and no other driver does this - and I'm not
going to do anything but if 0'ing large parts of the drivers to
'fix' the build because there's very little that wasn't totally
broken before.
Note that you actually agreed on removing them from the tree back
in June 2004.
next prev parent reply other threads:[~2005-06-19 20:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20050619113723.GA18757@lst.de>
2005-06-19 19:57 ` [PATCH] remove drivers/fc4/ David S. Miller
2005-06-19 20:40 ` Christoph Hellwig [this message]
2005-06-19 20:44 ` David S. Miller
2005-06-19 21:23 ` Al Viro
2005-06-19 21:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050619204008.GA26389@lst.de \
--to=hch@lst.de \
--cc=davem@davemloft.net \
--cc=jejb@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox